Re: [PATCH v3 10/12] xen/riscv: introduce p2m_gpa_bits

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 4/21/26 11:46 AM, Jan Beulich wrote:
> On 10.04.2026 17:54, Oleksii Kurochko wrote:
> > common/device-tree/domain-build.c uses p2m_gpa_bits to determine the
> > upper bound of the GPA space when searching for unused regions, so it
> > must be defined when CONFIG_DOMAIN_BUILD_HELPERS=y.
> >
> > The variable is initialised to PADDR_BITS and narrowed in p2m_init() to
> > the GPA width of the selected G-stage mode, allowing an external entity
> > (e.g. an IOMMU) to restrict it further if needed.
> >
> > p2m_gpa_bits is a global rather than a per-domain value, which is
> > acceptable for now because all domains are required to use the same
> > G-stage MMU mode, as dom0less common code allocates it per all
> > domains.
> >
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> Pretty hesitantly:
Could you please clarify what specifically you don't like here?

> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks.

~ Oleksii