[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v6 1/7] xen/mm: Refactor claim deduction for later functional changes
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bernhard Kaindl <bernhard.kaindl@xxxxxxxxxx>
- Date: Wed, 22 Apr 2026 16:18:50 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3dhHE4C2V+S7vfTWecnNFpItzw+ypjnH2myp4j86ApY=; b=cKAJ2wrMXuPFYUXi2rMNzkuuUsBw4VyPUoFrbVCLGDCc5CDkAMVKg1/abbgf8YB2Ufqf01C03g8TBRO7+ao0ex1rECLNnNXwp/+ty+kDtGWF3jG8jZu6khdujtnNoRxaZGjbBkVRxwv9dZSnCScGttfBXuTGqkkblT21LB0p5Wn58/fASOyu+zjUEjEPYSF53JfCQbq3YWl4dK2Ki67U08ZkpmFQ4QfVXNEC0dTBNbYfCMNrXF5h90Jeumfz0/1LFqNkWVbxEnasP9tDXl7O9LN6HAgNoCKcA+56GNLOca0D7eKNULLpQzyxXtsYUpn47Y9h3nbMSPZMfW7iEnk16w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hEMzqtywbgOdSbvboskv/unqJgADlWRDtLxXbZwD8S0S/nrMqy80JLv+r5iujz0Eb6k56ezdG8WgGIwTGVWKfnGtKgCPmYM8EjNeLedbK6wRNMiiHL/TXix0LLsNrn7LjO7tagVHYBPjmnRAjLlvHJm0+D6ljY19xachFA+jx318YorvuD9WQgKXKmezjEMuTpfT1/6f3v+M0hBjSQckvFVL55HK5oLzQF3JYaWA+b2keUBbZcfKTXctO5iGKowgwKX3KO8Us23HdepZaQkTH1zO+x1hJsCIBkDkuZ3QBmIX/PuuoQYxxpGBoCzU1nxNnf13750Ia/v3yjyDBPB/0A==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 22 Apr 2026 16:19:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHczBIVjQaUKhelwUCYpZQxzVcChrXqzwoAgAB242A=
- Thread-topic: [PATCH v6 1/7] xen/mm: Refactor claim deduction for later functional changes
Hi Jan,
The mix of unsigned long vs unsigned int for page counts is concerning.
[...]
I wonder if we wouldn't do ourselves a favor if we first normalized all
that.
I agree. While I omitted this from v5/v6 to keep these claims series minimal
(I had in in v4), addressing the type inconsistency first is the cleaner path.
I have submitted a standalone prerequisite patch here:
https://lists.xenproject.org/archives/html/xen-devel/2026-04/msg01134.html
As noted in that submission, this converts total_avail_pages and
outstanding_claims
to unsigned long and adjusts the ASSERT() logic to account for the move away
from
signed types.
Once the standalone patch is accepted, I can send a v7 of the claims series
built on top of it.
Best regards,
Bernhard
|
