Re: [PATCH v2 3/9] tools/libs/store: add support to use watches with a depth parameter

[Jan Beulich <jbeulich@xxxxxxxx>]

On 21.04.2026 18:08, Jürgen Groß wrote:
> On 21.04.26 15:54, Jason Andryuk wrote:
>> On 2026-04-21 03:42, Juergen Gross wrote:
>>> Add a new xs_watch_depth() function to libxenstore allowing to limit
>>> the scope of a Xenstore watch. It can be used only in case Xenstore is
>>> supporting the XENSTORE_SERVER_FEATURE_WATCHDEPTH feature.
>>>
>>> For convenience add a xs_watch_try_depth() wrapper, which will call
>>> xs_watch_depth() if supported and xs_watch() otherwise.
>>>
>>> Cache the supported features of Xenstore in order not having to get
>>> them from Xenstore for each call of one of the new functions.
>>>
>>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>>
>>
>>> diff --git a/tools/libs/store/xs.c b/tools/libs/store/xs.c
>>> index 06462445e0..cb3508a86a 100644
>>> --- a/tools/libs/store/xs.c
>>> +++ b/tools/libs/store/xs.c
>>
>>> @@ -1001,8 +993,8 @@ bool xs_watch(struct xs_handle *h, const char *path, 
>>> const char *token)
>>>   # define PTHREAD_STACK_MIN 0
>>>   #endif
>>> -#define READ_THREAD_STACKSIZE                     \
>>> -    ((DEFAULT_THREAD_STACKSIZE < PTHREAD_STACK_MIN) ?     \
>>> +#define READ_THREAD_STACKSIZE                    \
>>> +    ((DEFAULT_THREAD_STACKSIZE < PTHREAD_STACK_MIN) ?    \
>>
>> This is an unrelated whitespace change, and not mentioned in the commit 
>> message.  It should probably be dropped since the surrounding lines are no 
>> longer touched.  Alternatively kept and mentioned.  With either of those:
>>
>> Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
> 
> Thanks.
> 
> Whoever is committing this: I'd rather expand the commit message with:
> 
> While touching the file fix a whitespace issue.
> 
> Shall I resubmit this patch, or can this be amended while committing?

Of course it can be.

Jan