[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: ffa: fix build with clang/ATfE
- To: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 22 Apr 2026 05:13:46 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=epam.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H6XhVuBou+QiAULWpIvVnUfhAOkVWr/dDnjBKEQ+IfM=; b=mbGltR81MDmAYrYqjOxtjdmoKnsPQouew2ULW8DAGOirc3yitYrSUTYC3uHyCGfjQ8ZQfEZ7n6Ai49RAQHa+Enu0hsWjQgKx5jOdbuLPyP5ol5M4mAVHaD0cS/CNKgiY28KSUyDHWl1W9cwe9mcHG8/PEVmFQIkKr1lqzYX5caJje7/VIoPaLJlROi/8Nt+egM3hX1cZrS4v9kCyYDk7YcWdxWhXmzJoInWPSWcFeNPpnTH3Xx3RCBOJcO1NXbC+GaHRp2rWK1Ig4zJJlB/POJX2aIR+sCVMw7g3VOipGeqCZu4YhpStZIdmpdLAwI86OeJLyZg34/coAbKNPsIlzA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H6XhVuBou+QiAULWpIvVnUfhAOkVWr/dDnjBKEQ+IfM=; b=qnr7rz9ulHhpHeM7TljytObo3/PIRj9w8tojOf7TcsKiJzJUYcfEN0XodAQL9NRjDJH97sCaJBjohez8Nenwf/WIjrOpqPg4k0y2dDYgQqp09AhLcknEqgH4eTKslWl9V7piW2e0P537J8CaHaCLbCe+zJ2zgmNwOdak4SkJAmuXiu6hfIfdWTT5FckwiEUZHTVVBQQChtwtb6L1QuMaJP/GiLbdYsK+Z+rc4Wt6LxfkO4NaFFt8GlJwDubRhVbDinOsTal3OwsxMvtnkf29cCsP2DUk+4nxs+JfyzywnbCpK0UPbt5N6nW9DDTmfUFjsZOqe00W7k11akacrcy2WQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=Whv0coskLLhJNDna+qqc7Z8xzqjo5svPv3mG8J9v8I6Dq0xRFyjnrwhDI4jLJF6sSiWEiAIngKi5e/PcL1Wo+nbgGwMM50A8QZoYw84xVg5XovdADgQ414UeziD5iMWpSpnj82MrGPkLqBH2Ue1uZ4B8EWNBuKW5DkUxV6nArPRga4YgpiHClDRzu+PHf6ZOVy9p710oU0QXaZXD9HAkAGfRpfOLzfLsi2EtSUuRJkfYT+R0kYDNIoyZs1/V+qeWQbJVTYO8P0LNELA4WyN+r4k95rDwsGX7KFXPh5jPkk8QyoPHnSFtW3bwcyYSDDwZ6FF9xZDYxVjIoV43H18Xcg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Dt3tef974xQGthckB5XTgv6t2JuNIXqNEa29FMnLrPt4N8m9o1x6qhd/5uURMZSWifZl5nb9eJfaS2ePCaPrsVwY+UFh5mo/u8jBGkPzYkZ3Hly2HYGykFBbVKoYVISzpQ6u++lnTPja8wReC8YTeNYWgS0cq68JH0AXzlcLRX2dE5j9NUU12nxn+xIROvgap6oZgzgchbLAJ7fdVmLfvZceuPKUzsZV3zy/ivfVvwym075+K6/Nq9QpDugBpmVjOyBcvpN/v+3aKjjlAsF8szLR0dM2Wn/PxhZ01PFefeHTtYe0UdPBRuC7v9DfdKN5XY1P3iFaLmsg9mVWh+8icQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jens Wiklander <jens.wiklander@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Wed, 22 Apr 2026 05:15:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHc0WbA/s1rIXoAmU6+7rPJ118Z7bXqiryA
- Thread-topic: [PATCH] xen/arm: ffa: fix build with clang/ATfE
Hi Dmytro,
> On 21 Apr 2026, at 10:13, Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
> wrote:
>
> Clang 22.x.x or Arm Toolchain for Embedded 22.x.x reports:
>
> In file included from arch/arm/tee/ffa.c:75:
> arch/arm/tee/ffa_private.h:439:17: error: 'used' attribute ignored on a
> non-definition declaration [-Werror,-Wignored-attributes]
> 439 | extern uint32_t __ro_after_init ffa_fw_version;
> | ^
>
> There is a fix for clang 16 in the git history:
> a1a1e2b7dc4f ("xen/arm: ffa: fix build with clang")
> which was broken by the following commit:
> a90376c6adbc ("xen/arm: ffa: Add FF-A 1.2 endpoint memory access descriptors")
>
> Remove __ro_after_init from the extern declaration of ffa_fw_version.
> The attribute is already present on the definition in ffa.c, which is
> sufficient and correct.
>
> Fixes: a90376c6adbc ("xen/arm: ffa: Add FF-A 1.2 endpoint memory access
> descriptors")
> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
Sounds right to me:
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> Test CI pipeline:
> https://gitlab.com/xen-project/people/dimaprkp4k/xen/-/pipelines/2467446333
> ---
> xen/arch/arm/tee/ffa_private.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/tee/ffa_private.h b/xen/arch/arm/tee/ffa_private.h
> index c291f32b56..e16bc0d83d 100644
> --- a/xen/arch/arm/tee/ffa_private.h
> +++ b/xen/arch/arm/tee/ffa_private.h
> @@ -436,7 +436,7 @@ struct ffa_ctx {
> };
>
> extern DECLARE_BITMAP(ffa_fw_abi_supported, FFA_ABI_BITMAP_SIZE);
> -extern uint32_t __ro_after_init ffa_fw_version;
> +extern uint32_t ffa_fw_version;
>
> extern struct list_head ffa_ctx_head;
> extern rwlock_t ffa_ctx_list_rwlock;
> --
> 2.43.0
|
