[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v6 42/43] arm/altp2m: Add support for altp2m_flush
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Spangler, Rose" <Rose.Spangler@xxxxxxxxxxxxxx>
- Date: Tue, 21 Apr 2026 18:42:12 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 40.93.4.12) smtp.rcpttodomain=amd.com smtp.mailfrom=elektrobit.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=elektrobit.com; dkim=pass (signature was verified) header.d=elektrobit.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=elektrobit.com] dkim=[1,1,header.d=elektrobit.com] dmarc=[1,1,header.from=elektrobit.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=elektrobit.com; dmarc=pass action=none header.from=elektrobit.com; dkim=pass header.d=elektrobit.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zePeV6JogWVgPOLkUovX0ZChv8qdRTuH59k7XA3IYow=; b=J5p9zuvIC4o0c+hPio3K4CKPGmPpDGuMI05oki25DpazqizwuIKPJQ4JMmmUQjINfoBvB7IK1rwRqMHoWa1qzl5SMMkAwXFvHhBpEbxBvGiF6E/oOap6PdMB/65uJscTesyGkWHdDZQ3NwKj74ma0RJ/7rz04NQoczz9j5s2Vej61PqaPCHaWYLpmhlD8gqNAAQYy/9yr+HRMNG6kybbFhm4CXAO2VTnIkegbqgZB3xiJBHigbQGXH9O7Pmh5MWy6uKE862b3UEqQgO6lQMusWn02jFkf/UcYAzKwOe7kwkCz3aExTPpaV8sKfRlu0GHR7I4AndjUWHUUu2s7D3Pwg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zePeV6JogWVgPOLkUovX0ZChv8qdRTuH59k7XA3IYow=; b=HJKZKWSyWqrorWg/jr53wJ208IHkczKiiNRuBA7+m4Sm0J3MH3HzEQhvsrFGGda2+/Hlyp4o+svSsrKcHKy6SxLZEXlETK0yE34plTBMfFXEgGORLEPU6zBxfOm1zt2z29rHVepfmVW9uo/j+SLu3yFCFrhrvcE+pKk2CHHXdqgPxqgobAo2Zv1kyTO3ZnhXiwvr5HwJR6T6RHswoKCTmb0rjfdVv1BiyazWfOKFikHiSl5sCHUGIwLmRYurEl+IxDlyZGtCR+BsAXzryn88SI2MSn/B/vuhXVaCBgYEvZiuGdW3seFrpZWlf7NMIJ1BCneU0WejJc0elhYC0TVsYg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=ZktkJG42FToYIf+eiNQqYWSFSnUIc6+JM9ZwHvCdGPKr5B3sduzANYNH8iQzj2s2jv56rqa6nm4yKUfO8b+HklMq3YgwcOLgkWb9d+thR4c5HXmb0PqPRXf06QS6uAl/0h7W0s5TRxkeg+rVPSdMGznhrevN9rIKgOAQ63uAAJHuYJrTwhMebgoA4MfV6qWjIDRa3egqVykMsIIfwTGgPybGo9fWq7VF8IpAx7rHyahmfq3EzDf+VoAv9QvWPXfhr9YPQ37cUMdcGj7+QhCSvivzMuWViUbxBy6eCZn4r2E+OLnNOPd5e7UVFupCKhGa8SMaiGwv7F3sTafC7Cfaqg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jrXkpfs7wvnaPSlcS6hJvU2j4c29MEZUBOw/xOoR45KKPHNnhvyYkRq3SrGcevZRTGmx7+HhsXg6MRnAfc+6aEu1fyVvxB8vkiCtlmdwawbTzz3MOzHlzoOd3HqEK75cvaRfSY/OnJ9aR5TKk0Zso9Hlfff1NWriYVffvNpXykzX8M1pITuPRZWQfhkeu+mltjQOtV/pFV+KFVTiMCrbe75jNhNhJ7W6zVpHcf5Qk1XbGzr9GD3hRSYckUg1s7P/WePx3wClBLzgx16dH5ITonhIlHqNPHD+/nc+DHqfSPK5ZsBfxFyOEO5YnAKGpy0ZH5qk9J2VJTOYIxLYzHwCVA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=elektrobit.com header.i="@elektrobit.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=elektrobit.com header.i="@elektrobit.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=elektrobit.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 21 Apr 2026 18:42:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHc0Q1aXIo1jphIuU6k06S1vKsaS7Xp2JVR
- Thread-topic: [RFC PATCH v6 42/43] arm/altp2m: Add support for altp2m_flush
> altp2m_reset_altp2m(d, i, ALTP2M_DEACTIVATE);
>- d->arch.altp2m_eptp[i] = mfn_x(INVALID_MFN);
>- d->arch.altp2m_visible_eptp[i] = mfn_x(INVALID_MFN);
>+ altp2m_set_view_visibility_locked(d, i, 0);
While implementing altp2m_destroy_view_by_id, I realized that I set the
visibility of the views here instead of actually making them invalid. I've fixed
this in my working branch by adding a new arch-specific function,
altp2m_deactivate_altp2m, which both calls altp2m_reset_altp2m and sets the
views as invalid by setting the eptp/visible_eptp values to INVALID_MFN on x86,
and sets the altp2m_state value to ALTP2M_INVALID on ARM.
A side effect of this is that altp2m_reset_altp2m doesn't actually need to be
callable from common code anymore, so the concern I raised previously about
ARM's altp2m_reset_altp2m implementation needing a useless altp2m_reset_type
parameter is no longer an issue. altp2m_reset_altp2m is used in
altp2m_propagate_change however, so this issue might pop back up later.
|
