Re: [PATCH v1 18/27] xen/riscv: add vaplic access check

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 4/14/26 1:45 PM, Oleksii Kurochko wrote:
> > > +static int cf_check vaplic_is_access(const struct vcpu *vcpu,
> > > +                                     const unsigned long addr)
> > > +{
> > > +    const struct vaplic *vaplic = to_vaplic(vcpu->domain->arch.vintc);
> > > +    const struct aplic_priv *priv = vaplic->base.info->private;
> > > +    const paddr_t paddr_end = priv->paddr_start + priv->size;
> > > +
> > > +    /* check if it is an APLIC access */
> > > +    if ( priv->paddr_start <= addr && addr < paddr_end )
> > ... use that here? Or asked differently, again: Where's the 
> > virtualization,
> > i.e. the abstraction away from host properties?
> With the current use case it was easier to choose such approach then 
> provide the full abstraction.
BUt specifically here even with the current approach there is no too 
much sense to check MMIO of real APLIC.
~ Oleksii