Re: [PATCH test-artifacts v3 01/13] Add Alpine 3.22 containers

["Anthony PERARD" <anthony.perard@xxxxxxxxxx>]

I'm commenting on changes I found in the branch used by the pipeline
linked in the cover leter, since there's no copy on the mailing list of
the patch :-( (overzealous spam filter).

> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index c698612d5acd..17d25ce0f921 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -40,6 +40,13 @@ alpine-3.18-arm64-rootfs:
>    variables:
>      CONTAINER: alpine:3.18-arm64-base
> 
> +alpine-3.22-arm64-rootfs:
> +  extends: .arm64-artifacts
> +  script:
> +    - ./scripts/alpine-rootfs.sh
> +  variables:
> +    CONTAINER: alpine:3.18-arm64-base
> +

Shouldn't this use the 3.22 converner version?


> diff --git a/containerize b/containerize
> index 38a434ab7075..b3722b465e01 100755
> --- a/containerize
> +++ b/containerize
> @@ -28,6 +28,10 @@ case "_${CONTAINER}" in
>      _alpine-3.18-arm64-build) CONTAINER="${BASE}/alpine:3.18-arm64-build" ;;
>      _alpine-3.18-x86_64-base) CONTAINER="${BASE}/alpine:3.18-x86_64-base" ;;
>      _alpine-3.18-x86_64-build|_) 
> CONTAINER="${BASE}/alpine:3.18-x86_64-build" ;;
> +    _alpine-3.22-arm64-base) CONTAINER="${BASE}/alpine:3.22-arm64-base" ;;
> +    _alpine-3.22-arm64-build) CONTAINER="${BASE}/alpine:3.22-arm64-build" ;;
> +    _alpine-3.22-x86_64-base) CONTAINER="${BASE}/alpine:3.22-x86_64-base" ;;
> +    _alpine-3.22-x86_64-build|_) 
> CONTAINER="${BASE}/alpine:3.22-x86_64-build" ;;

If you intend to make the x86 3.22 build container the new default, you
are going to need to change the 3.18 x86 build container line above.

Thanks,


--
 | Vates

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech