[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 11/27] xen/riscv: create APLIC DT node for guest domains
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Date: Mon, 13 Apr 2026 10:48:49 +0200
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID"
- Cc: Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 13 Apr 2026 08:48:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 4/13/26 10:43 AM, Oleksii Kurochko wrote:
+ return res;
+
+ data = dt_get_property(aplic_node, "#interrupt-cells", &len);
+ if ( !data )
+ {
+ printk("%s: Can't find '#interrupt-cells' property\n",
+ aplic_node->full_name);
+ return -FDT_ERR_XEN(ENOENT);
+ }
Again, pull this up to be first in the function?
Agree, it makes sense to move it up.
But on other hand, there are several time used the same construction
dt_get_propety() from host aplic node then write this property to guest
aplic node, then maybe we want to keep this dt_get_property(aplic_node,
"#interrupt-cells", &len); where it is now to have the same visually
construction way of guest device tree properties.
~ Oleksii
|
