[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ARM/vgic: Use for_each_set_bit() in vgic_sync_from_lrs()


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Fri, 6 Mar 2026 10:21:33 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sFRT5nAckARuk4H+S4Yw9VmrAdvcJew+SYc7fWR7jhg=; b=vBlHjDlXw+2mpaSVtVWOZO3AND1D6C3kWbnbg6z5YQHaDsYTEzJMiipYTSyUNhJA4PrqpgCBSqJf2uDeoFuOnLnextfYY3JEDafxMRpSfLnFygXxf3ukgWDozZL0CrKXfPLxyiAjuLvseU/nYQWfcOvgcjpaJOK41xutGIYOy4DLXQ/FbrSKOrhBfTJ+z8N5sT4j8elWpxvGS0ffukCPrwWRtOCoCGFvmX9piCY6DCO/Mql53naF7pSuEQHO0J48z9UJ+MQmV6Mrc8sFjjV6Z0HpoA/BZ4ZxSU+oCh6x1FHVUtZ/CVT6/svgHS9eHOj4IkGEXZkd44m/SWl52sxUMQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wHpMflHJfgEYjP+XdcU6CaLPD3xG4Qgq7bffqEvV1AEqT/q4j3HNzkdFiM9Y8pIRrxChbkrsPCN9hntGuk7faT7pLJhf9vSlcYR/wjuRqsjj+mwsE2wihZfHTmrKFpXRsplAYfM9GrSCSVE6a5IA/kZPsFDuPyUirqml4mi3zH/umoIq3BA2UwVUSyOQCSiZNj0Zs8HaK48j4XQrfAxe+7ESAnrhkCZUBBDe2vjbFXEnsDbT0Eg+KUY+9Bio3EhHd2hxXOlun/NSXJgkJikplETMTIXFlZ1J5l+2/G0Oprg26vzrO8QquNQfg5Ch/7J8TP8pyv7sAa6KCkHDd6/bSg==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "Bertrand Marquis" <bertrand.marquis@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
  • Delivery-date: Fri, 06 Mar 2026 09:21:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 06/03/2026 00:28, Andrew Cooper wrote:
> lr_mask doesn't have bits set beyond the hardware limit, with the upper bits
> remaining zero.  Therefore, for_each_set_bit() is a better option.
> 
> For ARM64, bloat-o-meter reports:
> 
>   Function                                     old     new   delta
>   vgic_sync_from_lrs                           208     168     -40
> 
> but this doesn't highlight that it also removes a call to find_next_bit() from
> each loop iteration.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.