[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] x86/acpi: Remove BGRT invalidation code


  • To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Soumyajyotii Ssarkar <soumyajyotisarkar23@xxxxxxxxx>
  • Date: Fri, 6 Mar 2026 08:59:07 +0530
  • Arc-authentication-results: i=1; mx.google.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=XoxbFDZsmQse7pjbVYXTdtM53ZFTNHC86YvKyQzdLDY=; fh=5FPMNlxonDnoIoIMaWMAzT+Br+bG5xkQLfcZfXfS980=; b=byc4hknhqyA7q/WNZBiICPGJTA8N6/AWfY/PAU1jgksb0y5KVuvZp/LyHBo8g+tEzb tM2xtjkFvwsoALDDOVWsQ/51lxwc8qH1C5g3HKJvDesj+Ot1wIYw7Iu37LnhDSxkewrM /BDtN92/ZR2i/kmTIBwq9PjaxOlybt3rqlsfclXFg+7Q7a2MjyWKukb4nF7JO+9yjonn ROji4OZzkTygRNo3SZ0NpClBBqJUoRPAZZuegCBX+tcGE8uNdg2IGx5vTqbj/2y22Hqn FbSYUI4sjNuJP6xSXIqKW2esf7gt8J1goPBETfjzMTZESaG3lGWBI5g/HysqZ52JOMRH WD4A==; darn=lists.xenproject.org
  • Arc-seal: i=1; a=rsa-sha256; t=1772767758; cv=none; d=google.com; s=arc-20240605; b=dj314FPANkDIr3AMmNX9dEGmdKHbtns2FBWiu+5U3aIZ3utiG5t/BfBQRFjisJeBk+ yVxiLJpvva0CVyyRhk/X9UVOSTMB1qTP2NddJiRrPu4RPYgEL3GDlTcBHadgseumZEGf YD9/B1Bk0UsIr2HnCcUbiV+7Kdd3R0k+RodWrEKAXHsRYasAc/pzAV5g1x6gvc5o5e5U /NfPXM+ycMNEqrJ9tJD4DcCn1XTvqniow2OnqHvcsHn8yGQPQ5yvBheZJub9lRduYm1G +nlY5vrE2KRmQ/PWJGP3k3hb5NOBt2vJRfxM7nIObrkeGYPdqDUESAN7bwh273cyo+3J N89g==
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, sarkarsoumyajyoti23@xxxxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Fri, 06 Mar 2026 03:29:37 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Mar 6, 2026 at 7:23 AM Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote:
On Fri, Mar 06, 2026 at 12:48:09AM +0530, Soumyajyotii Ssarkar wrote:
> Now that BGRT images are preserved during EFI boot (via
> EfiACPIReclaimMemory allocation), the invalidation code in
> acpi_parse_bgrt() is no longer needed. The BGRT table remains
> valid throughout boot.
>
> This removes the code that was marking BGRT invalid when the
> image memory was detected as unavailable, which was causing
> ACPI warnings in Linux dom0.

When preserving failed for any reason, or when it was disabled (the next
patch), the entry still should be invalidated. In fact, the check here
for RAM_TYPE_CONVENTIONAL may already disable invalidation when it got
preserved?

--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab


I could move forward with dropping the [PATCH 2/3]. And adapt the other patches accordingly.
This would serve as a safety net in case the preservation fails for any reason. Would that be a valid approach?

Thank You,
Soumyajyotii Ssarkar

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.