RE: [PATCH v4 0/10] xen: Add NUMA-aware memory claims for domains

[Bernhard Kaindl <bernhard.kaindl@xxxxxxxxxx>]

Jan Beulich wrote:
> > - Alejandro Vallejo developed the initial version
> > - Roger Pau Monné updated the implementation and upstreamed key improvements
> > - Marcus Granado contributed analysis and suggestions during development
> 
> Despite any of this, ...
[...] 
> ... only a single patch has an S-o-b other than yours. Is this a correct
> representation of authorship?

Patch 3 should have S-o-bs by Roger and Alejandro in the commit, I will fix it.

Thanks for the catch,
Bernhard

PS: Details of the patches:

I'll also add Requested-by: Roger Pau Monné to the hypercall he requested to
implement for this series.

Here is the breakdown of contributions:

1. xen/page_alloc: Extract code for consuming claims into inline function

   - By me as preparation to avoid duplicated code.

2. xen/page_alloc: Optimize getting per-NUMA-node free page counts

   - Has S-o-b by Alejandro,
     - Extracted into a separate patch for more focussed review
     - Use node_avail_pages[node] also for avail_node_heap_pages(node)
     - Use unsigned (to be factored into a separate commit per your review)

3. xen/page_alloc: Implement NUMA-node-specific claims

   - Thanks for the catch, I will the fix Suggested-by to S-o-b's.

4. xen/page_alloc: Consolidate per-node counters into avail[] array

   - I'll remove it from the series, skip its review.
     Not needed, and it missed initializing nodes without any memory.

5. xen/domain: Add DOMCTL handler for claiming memory with NUMA awareness
6. xsm/flask: Add XEN_DOMCTL_claim_memory to flask
7. tools/lib/ctrl/xc: Add xc_domain_claim_memory() to libxenctrl
8. tools/ocaml/libs/xc: add OCaml domain_claim_memory binding
9. tools/tests: Update the claims test to test claim_memory hypercall
10. docs/guest-guide: document the memory claim hypercalls

   - These are the patches for the new hypercall interface requested by Roger,
     I'll add a Requested-by: Roger Pau Monné to the API interface patches.
     They are of course based Xen code, but not on patches of somebody else.

Bernhard