[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 4/5] vPCI/ReBAR: improve cleanup
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 4 Mar 2026 14:46:41 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hxei7N0ZENe5GUPjpfgHtnam0kPoo4xnJveyz9Th7AI=; b=hlF+GGh5ZIlBlP+/Q4QUVwhjSgNQVjp/IWM5A+vT2V90SvyPhXasYe688PQojwiSk1FMnHJKy/fTnBXw7fewXbTGHaVCDq6oGcmrdJy500xwbr6JscRNp8kyMXkx6rV6ZP5pq7mIJtbsNUcDyTmbj53x3Ij+0BhgEZnEyxu6XGmjnOm967SDi3t+UZNBOWvOa1pVrs4Xx4UkIWb1u+Bp7pRY0X6Ve5jMjOJ1zPJQR5k8hhwTZA40S4mfKZFtKGLMEa/+GPtKf8cIV4qT674/5FIbl0IsWSVv3O8H1R8UrNp6ehXGSa0ABd1P4Bp66bE1MgrVk58VT0Xs97A2+ZV8yg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VTwTDRf7O1aULMmJhJwLYyQiSK5dLU07N7Fd1VrXe82iw71RGsn/Z0U5ZYTzXcCHKIFf4JZ4gdS90GTOZBAKwVHapd0H5MG078resBQLiA3LbEAvRebHNX0oA1+qeOYAVELxT/h02rr4PIejZTI7xFoA3DIjWe9inRfKMNNY9neVGL9WOZJwTvhOY+edpbDAiU4KyihGXuuetcqETJ9B9sQlPMSnsYJ/XXu5e9boX3K/mfcRA6Fjo9Y7E4kbR8FRWfbvud3MfwIbN79RBUxG5Yoj54qxW4N4BdWYOGmTkNWJk1uzctnQgyR57s6a3hkPzqAoAaaX3K3mSfQ+Tr0C4w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Delivery-date: Wed, 04 Mar 2026 13:47:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Feb 25, 2026 at 12:44:22PM +0100, Jan Beulich wrote:
> We cannot assume extended config space to (still) be accessible when
> cleaning up. Necessary value need caching instead. In fact, as the caller
> also cannot look up extended capabilities, the cleanup function needs to
> cope with being called when there's no ReBAR capability at all.
I see that you adjust the code in vpci_cleanup_capabilities() in the
next patch, so that it also doesn't check for extended capability
presence as part of cleanup.
> As kind of a side effect nbars being 0 (which init_rebar() doesn't
> explicitly reject) no longer results in a bogus call to
> vpci_remove_registers().
>
> Fixes: ee459aeac096 ("vpci/rebar: Implement cleanup function for Rebar")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
