Re: [PATCH 03/12] xen/argo: Fix MISRA violations around function parameters

[Daniel Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>]

From: Jan Beulich <jbeulich@xxxxxxxx>
To: "Andrew Cooper"<andrew.cooper3@xxxxxxxxxx>
Cc: "Roger Pau Monné"<roger.pau@xxxxxxxxxx>, "Stefano 
Stabellini"<sstabellini@xxxxxxxxxx>, "Julien Grall"<julien@xxxxxxx>, "Volodymyr 
Babchuk"<Volodymyr_Babchuk@xxxxxxxx>, "Bertrand 
Marquis"<bertrand.marquis@xxxxxxx>, "Michal Orzel"<michal.orzel@xxxxxxx>, 
"consulting @ bugseng . com"<consulting@xxxxxxxxxxx>, "Nicola 
Vetrini"<nicola.vetrini@xxxxxxxxxxx>, 
"Xen-devel"<xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Christopher 
Clark"<christopher.w.clark@xxxxxxxxx>, "Daniel P. 
Smith"<dpsmith@xxxxxxxxxxxxxxxxxxxx>
Date: Mon, 23 Feb 2026 04:15:55 -0500
Subject: Re: [PATCH 03/12] xen/argo: Fix MISRA violations around function 
parameters

 > On 20.02.2026 22:46, Andrew Cooper wrote: 
 > > For the ARM build only, Eclair reports a R8.4 violation because 
 > > do_argo_op() 
 > > cannot see its declaration.  This means that x86 is picking 
 > > hypercall-defs.h 
 > > up transitively while ARM is not.  Include xen/hypercall.h explicitly. 
 > > 
 > > Eclair also reports a R8.3 violation because of arg3 and arg4 differing in 
 > > name with a raw_ prefix.  Because hypercall-defs.h generates both 
 > > do_argo_op() 
 > > and compat_argo_op() from a single description, it's not possible to 
 > > simply 
 > > rename to raw_ in the declaration, as that would force doing the same 
 > > rename 
 > > in compat_argo_op(). 
 > > 
 > > In do_argo_op(), drop the split parameter handling, and perform the 32bit 
 > > range check via an explicit cast.  While adjusting the surrounding logic, 
 > > drop 
 > > unnecessary casts to void * for already pointer arguments in 
 > > argo_printk(). 
 > > 
 > > No functional change. 
 > > 
 > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> 
 >  
 > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> 
 >  

Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>