[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/12] x86/shadow: Rework write_atomic() call in shadow_write_entries()


  • To: Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 25 Feb 2026 12:14:49 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qJbLflT1H1pA49mG1130YzMZbQNUbdmlmar74HDj+Ys=; b=OjMzov9M1wNZC47i8orwAz6PTWeh9RzbK2hffcz0QA5YRl97e0HtLvo/iL/bzL3NTv+luGtYPp5HTzea6BtfgSQovHIpXAbPdl6nxvREqd1DnbtQU8yDhwFXYEBuU4gfrHJgvTXlx1kfPIiNsDGL4sSlWlHj7bHyP0RH+Zb+QiPQo6641bSpIETqBzYW2dPpCT4kZL8qU1RigB+DRau6FsRxwE8/hgGYtCR2relOf4xSiuvCHBHgXDodxIJHyBMEWoQHaIQfky5ridoh2gejnUR81O4KbNeLzwJToMED6krH62XkWuw2jTBdA1ReuQm0T/eaXdG/OCSfXSwyD7MAYQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uLFMXvCBvNrYZIDe3wsVAWJ+Th/FM6xAQbRqUTsWBF+RyUGECjoPrMS2QH+ssMfe4bpgq7+UetTXg0i/j12lmTzL8DOXohtDcn7K0f8XnIZ12+oGgye6xeZuRwoBI1CYg703uDpagmEijH3oQ3EBb4jHtOPXSIoA93aeM9LhcEp4ruxkVjEmfOFguhHekkY7iXUfKZHgrEQveH1meKTA32B3ulsRrSa7Ohh/8RCOthSumCULBU4FHEOhgUXmUqH3+VLkVoNJJYIM0RGmewuCVxVPTaM416m4g3iLFSj1jtLyFmCNq15HdIHZacZ+0wS4FkJCuHPfmIECbkSGZHMvMQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "consulting @ bugseng . com" <consulting@xxxxxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
  • Delivery-date: Wed, 25 Feb 2026 12:15:13 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23/02/2026 7:26 am, Roberto Bagnara wrote:
> On 20/02/26 22:46, Andrew Cooper wrote:
>> Eclair complains of a side effect in a sizeof() expression (R13.6).
>
> I disagree with comments of the form "Eclair complains"

We use the same phrasing with other tools too, but I can change it to
"reports" which I suppose is a more neutral term.

>
> Note that in recent versions of MISRA C that rule is no longer
> mandatory.  More generally, note also that, IMHO, switching to
> a more modern version of MISRA C would simplify compliance.

Ok.  Making things simpler for compliance sounds like a good thing. 
What would this entail?

Presumably we've got to adapt to all changes in this newer revision of
MISRA C.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.