[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/efi: remove unreachable efi_halt_system() function
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Tue, 24 Feb 2026 14:05:10 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dvnv/VbGJdkyy1D/PtRyAfHEXoJ/d1hWLcP3Y0G/Ej8=; b=AVm0zOUiIIlmGV2CLjhwmzCIJos2E9zlKShm3655A7ijivaITx4i2RpApPWsPjA237D816CZSfAVikbjzl68yNMFbJeqncaP40soK73PWYbtFK33Uqem3QUGaGCgHbYMSArj+ZeMyjm0ZEYUogjHIBX/RtnEP2jgovG20gqeyrXZi7pOCLQebeqK5orPg5nPUqq0ZKnxfUQbYMTOZHHh7iKMOeowbZdhIcTO7VWAXqpvYD67JAdmIw0ToAbtzefl/wrzLKZElfGB3EtzJB4hrxBz+YD9JWgNf5Y4Yzqs3prrhdYTBAhhH2B71UCpgnZytzt59ZxJmS74G3z0PYxPww==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CoR/ToMfEfCJHqK2nioYzPnhgB0qMODIkKZRMW7HMJAP98hg08iTUv0Nsk1ZHLcdy9Wd0XNaWLla+0MxX7rU8LWxRyEv/bgD7rGN1QTltpmGU3mVnyBZd+MqBLxYN6gnQ/DiLQOmFjXhFOoXrxZuavNDPKTrlOLOQwj2uVRLZQFaXfvepSyHCqzGYqFYtztsk/eiT60s9WILyUZnDcBCGCvnctsofm4afoz1FZ191euzouvdtcETh0LTNA8szBccctUYYEsMhullj7Qyc/cDCjPwJfaKbf4ArJCFecrVUD3DXUAnPYM/DZg1HlGrJOcjJiknB7484AWVD/0dLcXjiQ==
- Cc: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 24 Feb 2026 20:52:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-02-24 15:07, Roger Pau Monne wrote:
After e4c3755d4dd7 the function efi_halt_system() is unreachable, remove it
from the file.
No functional change expected, as the function is not called.
Fixes: e4c3755d4dd7 ("x86-64/EFI: don't call EfiResetSystem() from
machine_halt()")
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
I see this dropped with --gc-sections, FWIW.
Thanks,
Jason
|
