[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] wait: drop wake_up_{all,one}()


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 23 Feb 2026 15:27:51 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RD6EGVMj/RXjZfLDvyRwa7LgHV4F59El5tlUhzDwmnc=; b=BJIOeDtlJGJabyUS/i+0tSM7h2cO1sbzlvyTSej7x61ra3h/ku31G3HXOjhDuRQvg/oY7kCoSmfWHeF+PM1zRS77UXx/e5rhLte+aKFJhpCtFiCo9fZtHQq/u7JOcZaImbZI09vDDx1U+W9kYDbTT+DkBcsSoNTSnodssKMkEIiL/xH3wNbxN0WJ9qB4xnImJTYkEdEcyv4I2DeYg5ki5tlhs+QLIoghKdm8+dcdKWtM+T2Wf6xzB5OYkECQNj88CJR+20w5NTicgoOaNFIHXNeXayn7UuCDJtaIwRJOPwZ/hbRh2pkyXnkuTvrVM298N+OAECeCGxtCMjCO2h8T2g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=U8L8zRDVKdXmHewL1ZdHhEeUz9s6WubMGihK2jaFe447QOmmyf5Mxi8xuJG/tTa5vDs6bq2ifpsPa25Ahm4Fr4N7UNgEMvUJXQTY2Nu9iqhOU6RG6AUHLQctaMeZJKFQcM8iAVpLy27XWLsw4bqvw3GJo/L8H2MD+D/WQMaqyjN7aT9ByKrmhoottDx0z5j9doHNeq5aNl0hR/KYuRxHALMqOAqAbU+irs+hoQlZ6xo0H9xJvFhaO+1Nc2J/GHX4JYMwcurxgMF/BGt4eK9IGusX6OuRUrMCp3pYpwTna2P93q15+zFBUidDSvvwqwgLbd/v6M3kr1a4qlA7iH9l4w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 23 Feb 2026 15:28:09 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23/02/2026 3:09 pm, Jan Beulich wrote:
> wake_up_one() isn't used at all, so violates Misra rule 2.1 (unreachable
> code). wake_up_all() is only used locally, yet rather than making it
> static its sole user can invoke wake_up_nr() in the intended way directly.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.