[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/12] arm/pci-designware: Fix MISRA violations
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Fri, 20 Feb 2026 23:15:37 +0100
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1771625737; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=EN/3HH/VIPh5HXiOGshM4hir4fjZy/kgf/ECL5VqcoU=; b=stgJLXcEFrVbzWQkS6S+idXdJWZlb04/xrXTq516cPxVW5WRHYsuP1GfMhamv+qHm5Ix k3BguW5Sn0uvNQbGE6pSrTRFuiHjgr/WHaiv93gAzViCFxM6EMZaHnbxxv8qI5BnQC0yT dDg21o2ee1F0+ht6+ovXi7SLXt3BBUsNF9wDmkY5NEH1m3JT6gbwwyQ3RVax7ZRIQTbsM 6QWDmxFJ+ISU/N5Fj+Pw2YfXU/HLDImF+MdQqk2DWw4QOK/TrLqNTxHvRTZM2Ghpx1r2A dXp46bjKIEUIon0zdGJRXgVPW6K+zr7Bbhn9Xt2Pt9vX/6hZd/S/RWdOg7SFAaXB6YrP/ LEkGTH0H1l3+V0jd+N7oDlkCpVuVDmVm9GgSBZVF8pPeF6vgIy3o9Io/Tc+ywzZv66a8m Qm5h9a55pN7UEEZwJ9YHPzIgGSbEwx98t1ygyW7dTzh9MYYy6UGwmqNcVfef59l+LzGtE DMS45oINW7zuEVv4PmwmGhw0cayuDTzhkZoLO4aHc2xfqONDn6MQ43BGC7G+zU0F5ZzoE RkeRiKmler66ef6wREhPOSO/HFgvsaZAIjBnJiqHb8+tAjEH5IBrmh8cvlUA6FPV36+s7 N7eKezKMkJBVLryc73R7WW9NfspE/0hOO86hr0ETeeqhRBZ6DR7ub1CQ8w0/3U4=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1771625737; b=Jy9PZvmv0XHVgphT6huxJqKJHg7OZZSYtrJ58L/2jzFt/YqsTne+vYgfWGGLKM22i5Mq IvdC/6tvJL1ex018at1UAQqRvIqHeSEPaFqTYL8piBixFDtBag0UOvWKggrtmDRC9R8ZZ jHc8hHztDy51mzS+kU66iPb/69Ri4hQ8PuyIoWAjrVqhHZsm0i0XlCS1vJSQfwI1goJtT tEgYsoAt+yej02GG57Cct4qIiH3m/r1dwRIiIdBAaO3s751DV2NnEMF4ridlJ82M5qF5K IcIpSVIIOLvgrM/o7BiJlZdd1BQ3HdHnkb3fz+tNOoqp/iPFz0Px4Tv9oWrEA8/AdQ4ka QOz+FApBNkSO78dspDVmm8Y/EV026u1hDTlJ2m2/Rnk5Aotd67kNTiiKPZ5bEj9iGYWia tqRxOR18T17afA9WK6JUtemRfOPjVdLlOTreGu3DcY06AQqKjl8uLMtLDQmzKZjqSphbE /1XRxDL/1JB4yqabdc4jBKAHWJKeMnKBzktuDlXiVipl0DOq8G4pevV5UUalLF4MaVyW5 4HvZwcIifLvTKrOrtooGSCAGKfS0z2lYr/wkwfIlgoENTrCpuFMamHnXnrp24CKMhZi7K gsRysVeUR+iaGUvJ7zFoxxvw1vJiEQH3dqltSTJeQlZSU4xsucp29n/2hAF3Jkc=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "consulting @ bugseng . com" <consulting@xxxxxxxxxxx>
- Delivery-date: Fri, 20 Feb 2026 22:15:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-02-20 22:46, Andrew Cooper wrote:
* Move includes inside the header guards (D4.10)
* Use NULL in preference to 0 (R11.9)
No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
CC: Julien Grall <julien@xxxxxxx>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
CC: Bertrand Marquis <bertrand.marquis@xxxxxxx>
CC: Michal Orzel <michal.orzel@xxxxxxx>
CC: consulting@xxxxxxxxxxx <consulting@xxxxxxxxxxx>
CC: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
xen/arch/arm/pci/pci-designware.c | 2 +-
xen/arch/arm/pci/pci-designware.h | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/pci/pci-designware.c
b/xen/arch/arm/pci/pci-designware.c
index 0bd67524ac8b..6b85213f637b 100644
--- a/xen/arch/arm/pci/pci-designware.c
+++ b/xen/arch/arm/pci/pci-designware.c
@@ -285,7 +285,7 @@ void __iomem *dw_pcie_child_map_bus(struct
pci_host_bridge *bridge,
bridge->child_cfg->phys_addr,
busdev,
bridge->child_cfg->size);
if ( ret )
- return 0;
+ return NULL;
return bridge->child_cfg->win + where;
}
diff --git a/xen/arch/arm/pci/pci-designware.h
b/xen/arch/arm/pci/pci-designware.h
index b9deb3b138ae..bd93dab6f2f1 100644
--- a/xen/arch/arm/pci/pci-designware.h
+++ b/xen/arch/arm/pci/pci-designware.h
@@ -6,12 +6,11 @@
* Based on xen/arch/arm/pci/pci-host-generic.c
*/
-#include <xen/pci.h>
-#include <xen/init.h>
-
#ifndef __PCI_DESIGNWARE_H__
#define __PCI_DESIGNWARE_H__
+#include <xen/pci.h>
+#include <xen/init.h>
#define PCIE_ATU_VIEWPORT 0x900
#define PCIE_ATU_REGION_OUTBOUND 0
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
