[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/12] x86/shadow: drop is_hvm_...() where easily possible
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 20 Feb 2026 15:14:31 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VLqNqelaA8nRP3SfuKZEN0FkjhVEzjTdCxS3OB1A6iA=; b=atCFaVdHOSmI0soYzbE9qHULnZOsIFJJXoKH7X26rf4aabknpwvEex5Vj92i5qzohPNRwz93qJUdT5Cuhx2JZtfHOxKTkAiV7bYCqR8limsYZcbuzDMlDZO1pmMHCuqcdoRsU+TtT3s3fqIT9mrVaJcd+C4zRnoP07ZZsujjcfqTR+1fkXrYVndLe5OC5hUxJMFCp1k4SIzEwpATyHbaj9+9+zrARpqlWTtrabFonyfJLonMYUiTjVbRfGc88keZhJ7ua2wC8QPfiq6/RgZjrEzSYWnq9CZ0vxav6wS0D3ein6cVKx8r7gvl+1dkxPBDjsBsHTn/xr9pKjLpLuyLEQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v3AadSxYLqie4DyfUb6UAHUy5TUleKm+dlSSy7wyrqV81AZrRWqXeC0rxG6PdHk974Uvfl7Vi1cTeuBRHefHKQuwoUZuGRoLNfkMpIgNwx4cJYebkEn/fd5P3chJ21XSlpOJPBrkIVN8i/PWp3DaQJzIqGN+5D1orRspqjBx+s8z9wQB7egrGbNZhsyZZwzwEy1SiaKx7C7jbYsuD7BG+CtCVCxNZxM0vJg85Au4FKZ9EL6Qdu1U8+seD7AqXcBk3xfOTjPglzfFtnU/bb+IJcf2WCSlVK5s/lz5Nmqfr1adT+dBEe8+TOb7MwDW2xPkHz+s+3P40xeztFBOLLXxHw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>
- Delivery-date: Fri, 20 Feb 2026 15:14:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/05/2023 8:41 am, Jan Beulich wrote:
> Emulation related functions are involved in HVM handling only
I think this wants clarifying a little. *These* emulation functions are
only used by HVM.
pv/ro-page-fault.c does have emulation for PV guests, but uses
paging_{write,cmpxchg}_guest_entry() to enter into the shadow code.
> , and in
> some cases they even invoke such checks after having already done things
> which are valid for HVM domains only. OOS active also implies HVM. In
> sh_remove_all_mappings() one of the two checks is redundant with an
> earlier paging_mode_external() one (the other, however, needs to stay).
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Preferably with the commit message tweaked, Acked-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>
|
