Re: [PATCH v3] libxl: constify some local variables for building with glibc 2.43

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Feb 20, 2026 at 03:06:56PM +0100, Jan Beulich wrote:
> On 20.02.2026 13:12, Marek Marczykowski-Górecki wrote:
> > Archlinux just updated glibc to 2.43+r5+g856c426a7534-1 and that
> > causes libxl build failure:
> > 
> >     libxl_cpuid.c: In function ‘libxl_cpuid_parse_config_xend’:
> >     libxl_cpuid.c:447:16: error: assignment discards ‘const’ qualifier from 
> > pointer target type [-Werror=discarded-qualifiers]
> >       447 |         endptr = strchr(str, '=');
> >           |                ^
> >     libxl_cpuid.c:452:16: error: assignment discards ‘const’ qualifier from 
> > pointer target type [-Werror=discarded-qualifiers]
> >       452 |         endptr = strchr(str, ',');
> >           |                ^
> >     libxl_cpuid.c:454:20: error: assignment discards ‘const’ qualifier from 
> > pointer target type [-Werror=discarded-qualifiers]
> >       454 |             endptr = strchr(str, 0);
> >           |                    ^
> >     cc1: all warnings being treated as errors
> > 
> > Add missing consts. Note in libxl_cpuid_parse_config_xend() non-const
> > endptr still is needed, to be compatible with the second argument to
> > strtoul(). Add second variable for this reason.
> > 
> > And while at it, move semicolon to its own line
> > 
> > Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> 
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> I'd like to note though that this can't be all that's needed for tools/ to
> build fine in such an environment. xenstored/core.c has two problematic uses
> of strrchr(), for example.

Hm, it builds fine for me, not sure why.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature