[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/5] vPCI: introduce private header
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Wed, 18 Feb 2026 16:58:40 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ABkrx97HXuyxoaYIfUhogiitLDbx8qZvT+AMeE6TcHY=; b=cZVe709WdR/Te0MG4hhHs+gDIParUoYSjlHK/k+60W4QylfubI4P4hZaZyCxmu0xIq9+CIBPe9OtVSqgriA3jFDgtz+3WhZLU3J6P9gZhFnfQ4eOL3kA3enBMuKRziYl/Ogbmu9dK4Pi715wygdxWlEAs39W9HQAbZgljxIS4liqqtJ5kNYVmGTlMQBJASJMpZ6hF9M3LVrV9huwdPcO5GsviPQruV/hGSuV+O7dbLGjunJRXrVLORpXPw8AxU2KwpCMGeXszdHnYmGi+b/bzjc54SkXuHZ+1Pe4zaJ+/zC1g24dIY2XG8PhzF4cvZiLHbMUfk9N1B7bOZhrGagg5w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gtsSqDmgAiSvW43Qmwxuv6RWmpQwc9r/nj7+/sMRpBqifRLkng5ZL1hAd+hKfarX0RteRh9Ueg1Gcwr3Ih68o3STP3GHrgV8XgfQprL0c4mXLltcXEcDNbDevpz+0QPdZ2gBL4WDhh9sw1yBVMALl2J2d+yrKRI+qHXt+l3x3PeHu1EuQI+9n1Na7qccU3dvoGo82Ot1wxRSw/uMs0kvjbc8qKGUNEqgDq716vyvUg/8eUJRzhR2IfB0j+ii2R2pFJVLvh0t7wTVRvF9/VZ5aN/eSbnPF7+O5jKWd36vFFKPNLQFncbJxC6reSCjhLVpHWxdyv5/G94N1QNk6o4IsA==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
- Delivery-date: Wed, 18 Feb 2026 21:59:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2/10/26 05:53, Jan Beulich wrote:
> --- a/xen/include/xen/vpci.h
> +++ b/xen/include/xen/vpci.h
> @@ -30,20 +19,6 @@ typedef struct {
> */
> #define VPCI_MAX_VIRT_DEV (PCI_SLOT(~0) + 1)
>
> -#define REGISTER_VPCI_CAPABILITY(cap, name, finit, fclean, ext) \
> - static const vpci_capability_t name##_entry \
> - __used_section(".data.rel.ro.vpci") = { \
> - .id = (cap), \
> - .init = (finit), \
> - .cleanup = (fclean), \
> - .is_ext = (ext), \
> - }
> -
> -#define REGISTER_VPCI_CAP(name, finit, fclean) \
> - REGISTER_VPCI_CAPABILITY(PCI_CAP_ID_##name, name, finit, fclean, false)
> -#define REGISTER_VPCI_EXTCAP(name, finit, fclean) \
> - REGISTER_VPCI_CAPABILITY(PCI_EXT_CAP_ID_##name, name, finit, fclean,
> true)
> -
> int __must_check vpci_init_header(struct pci_dev *pdev);
Nit: I suppose vpci_init_header() could also move to the new private header file
|