[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/arm: fix unmapped access trapping on GICv2 hardware


  • To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Wed, 18 Feb 2026 18:16:19 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qVEs37iEICqA10CmlFdhVS6mAF72WkIANr/RNcX0KiU=; b=wq2bOU2ULSnONoHC/Pqa3S5kP4nZUhnCWSqe8G+VxfTu3T2ekfvTrQP9QhgBnh+Ry3wNiCn70b5yxOfwejVrpRzmQirH7OXAXzfjgBqQeK1U8VAQhtrXCN6nMTUZ5CHCccNY/c7eN9JNJU/XnKDuIOFIJZ9I6AbJEntQVwHLTBip/KJ4oU+drzePJb3XbBmUGzClDpwYIksYmETtNTkRmPY+novbTblsIjXQzvpmqHNZgATfhDvlivHzzo1bgQXDCQHGpJ2wdEOoUsurLY6XYEiA1+9thfXO6JBw/+GhAptp7KSXr67i9S89w0dCnLBasqIm42HdtZpLxoYm9ApGfQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bkPMFphUQVi9e6Pk/K3A5+59FgvQ8JzLjzkcIvmlODy93rM2AUd35UgQI39oqkLqKHwQhOO2DbBmIe6eoaCH2aKVmVHNrA2a19zlaquW9vCUFoCs1aTni30m+WEN8dmsTSv34Yj37vTuJNoewi76KSOvyzRQOrl44eDAGr1uPnOqfdu/gTgsnNPDFg4VVSTe354aPMuYZv5yqMk4Z2Cwnm4hCVrOR98qXV979wd1X9f8JosMtMniyE1WV/QDQtq71hidhv3cQ1D8gxywKJ/C8P42ftEm3iV7ucHp0Fa+Zscxy7APEzYs11Uu8m8um96oo95t3hqU/oQ7uyX/SdQeDQ==
  • Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Wed, 18 Feb 2026 17:16:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 18/02/2026 15:21, Stewart Hildebrand wrote:
> Gentle ping.
Sorry, I'm quite busy these days.

> 
> To be clear, domU interrupts with vGICv2 are currently broken when
> XEN_DOMCTL_CDF_trap_unmapped_accesses is not set.
> 
> On 2/5/26 14:01, Stewart Hildebrand wrote:
>> Since 4dbcb0653621, the vGICv2 CPU interface is mapped in a deferred
>> manner. On domains with XEN_DOMCTL_CDF_trap_unmapped_accesses unset on
>> GICv2 hardware, the vGICv2 CPU interface fails to be mapped. A visible
>> symptom is that a domU gets stuck at:
>>
>>   [    0.177983] smp: Bringing up secondary CPUs ...
>>
>> Move the 2nd check_p2m earlier so it's prioritized over try_handle_mmio.
>>
>> Fixes: 980aff4e8fcd ("xen/arm: Add way to disable traps on accesses to 
>> unmapped addresses")
>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
I investigated whether the reordering is safe and it looks ok:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.