[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86: Force HAP to be enabled when PV and shadow paging are compiled out
- To: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 13 Feb 2026 20:54:08 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xlx36ml5HfQ3qyFlB9kUsHK5uCFO73NpFC9Oi2ci5R8=; b=pjeQA3rGGG638jjb8d5eDSjpkhmuK+O3Shtzn9BamwHNm//qRbFK0ZZeXdUr5usX8tnLZdwriJGhu8LUMYuajqO+4WDBqQg0RSC7lPS8/nBh52W6FKv4R7Pk1iLcKV6T29IpBTf6zUbYSEHpSbNeVs4hjDS8sMxgg1DW/TGrgH8e0bmEtKnujNqga/VXGVi0HsMt4m6NuM4SJDOlkkqyD0WwPNQ8vZ6JTOAqZ4oDw6KrNStJe6hg5LUA+DfGF+/QVCmW4j3KRS3jYWuLfxlPxcqQ6k5Qy8WearNdJIqnwQ8Z0JYA9UkNzDAIU/YwHbOdKia/VWLIy2fpQkZfmS+tMA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DE4vKVzsYETZhj8t33AflImwxnExg0iN8osy+EjChbRDrV2L+ZQakI+q4nT0xICSTmmMvuJm8Pfp9cwGUMl7N81XN8XCQo2ZBJvoxyq0FmwCDHNY7DgLn2ZMjoruIymxftIzdKxiZkpeCOf5gBYAmx1N/jF0f8hVgzZF53Ki3W2u1+cT7ivI1OjXA3jlIAqxHOBRAiOxewdSIGAU6mC53VwtZX2rzb26wwB6mQmCY/bBMKu7UsHyyC4SEmX/LK3uU+gj45evFyKrjThPlX7JKWSMB1L5ySugZZNcFnUfsQ2RGerg9OG8EgqoZU5CaF0yWpPBdrYw/Cag69YSgmiPNw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Fri, 13 Feb 2026 19:54:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Feb 13, 2026 at 08:13:09PM +0100, Alejandro Vallejo wrote:
> On Fri Feb 13, 2026 at 7:42 PM CET, Roger Pau Monné wrote:
> >> >> diff --git a/xen/arch/x86/mm/Makefile b/xen/arch/x86/mm/Makefile
> >> >> index 960f6e8409..64fde82c50 100644
> >> >> --- a/xen/arch/x86/mm/Makefile
> >> >> +++ b/xen/arch/x86/mm/Makefile
> >> >> @@ -1,4 +1,4 @@
> >> >> -obj-y += shadow/
> >> >> +obj-$(CONFIG_OPT_HAP) += shadow/
> >> >
> >> > I think you can use:
> >> >
> >> > obj-$(findstring y,$(CONFIG_PV) $(CONFIG_SHADOW_PAGING)) += ...
> >>
> >> Hmmm. I guess I shouldn't just include it twice, like we do for other .o
> >> files.
> >
> > I see, so use:
> >
> > obj-$(CONFIG_PV) += shadow/
> > obj-$(CONFIG_SHADOW_PAGING) += shadow/
> >
> > Maybe that's simpler really, and it's a pattern we already use
> > elsewhere.
>
> I meant them being folder with makefiles potentially doing things that should
> only be done once. I don't know if we dedup tokens somewhere. These makefiles
> are rather arcane.
I'm not a Makefile expert, so I might be wrong. We apply $(sort ...)
in several places to remove duplicates, I would assume, I see:
# Subdirectories we need to descend into
subdir-y := $(sort $(subdir-y) $(patsubst %/,%,$(filter %/, $(obj-y))))
Which should remove any duplicated folders.
I've tried the duplicated folder addition to obj-y and seems to build
fine.
Thanks, Roger.
|
