[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/12] xen/arm: ffa: Add FF-A 1.2 endpoint memory access descriptors
- To: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Thu, 12 Feb 2026 16:11:13 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=linaro.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GdeApeURvFvT/CvvTI4dLgaDQqmGRGBGTQ0aOhn9Tbg=; b=HgBPDVE579WzzePHFA1GOu2J4UavTUylhc35xHcwNeh5/tSfRWZtENrreOug/3VauiI0XXn0vLgzUsfQ9eNdhzzBdr72I5FZs2FTozt7/oLvykclXGik5kaA6EzvVPqsbNknkUuSmqGRPBT/vGN4iQekXpCBE2AAAhUlZ3csrMmlNejMDW8rFvdpMIYyjD1xdm+SYLVVYYfPCJci019W/VrXEj+187S2mnbNfVuRVWRaWz5o2NIwFsuwsj9cK8NMNU4WV1xrw1IJKGeFGjkDjZFfNCaaBkE2OZ796ne+zhAvRfwjt3XpNKXOlAJ1PV0sqWPPo/GPLGB4Nqrz7DbkMQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GdeApeURvFvT/CvvTI4dLgaDQqmGRGBGTQ0aOhn9Tbg=; b=meZ+sF6csGsSOCxDIAP92+VqVXaD9V0VGgpo/U0DO7CQX7X/hvgNp7M95FDZeDpOcLJ6Vq8kzuXW67PQGURHEEtXzzZ9NT2SPufz7PgHg3es+8wtHI8tQj6Bakb6C5u7wsfXamGzP539kpMuWfDTRQNMDws0Anv80/jb+cwW8s2o6ekUubwT7TQzmzPUpj+JwDp9R5RtUzO+1mM7Lz0oM2GIJI7gVcxMto44Eib7k+emxFq8Umv9NhsUmqsK+3GDTHI0ppbHhU2pHWm5PDIuSuRMYf7YbMlo7TmR9OIhuElThutgkn1Dgx5QUamgy6jVt76ANRwGS9SeJh4MZyw1Bw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=TSE+vUfG0epM7M+K4168Rilf9x9XPWBDDOYoFthTIWnbRdFPJB8nIc+Jl21Os7ss7M2rEwTDB+jplDm6/6UGJrQHhLE7bVNDpnGSDnxpAimdxUX1zQ+Am1IeKaNUkkHxxL2MiyLiwJnJlqwr3DW/3Qs4SS7GsJcfhNAQp9xmQw4gcaTNyq2W20YOqtiy5OPv6NArR0yxo6RN2dxZp00EAyVD5uLVNN7OgUhJ1vKlwbKU0rQ5eq0X3LubOKrYJXwBJUEtV3Sf3hThU1rjKAGbSJ8f8hNBrFe6kCVSvJKHof7/3Dnabh87I7q2oUGctoi/3emT3nZ2+TzxxLCR7Uq+DQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J87XbuBv+SR2JdE2R5p/VaB8VVZRoIVaUw5XNWAqe/AvAx77jTzKDd8aDgHwLin9ncTIbQc+7T4xLXWAy0jO4TLErstpYKOeMj6OpYj66/+IMPVr51knyujHcYUpnuUpQSd8bCclxMFkfWnxyUJlAJNCTyT5cVA72SJYdmGazkU8UHSZbNYv3i2nvA3y07cJbrbTv3svoXbyBUn/HgAld1sFD/4nxWdcWBiZ2pMwAtlBzRuMhZguyAVhQLCORzDttZK7doxwIty6pzAi68imyy8Tt94zNXq++HU4Da6oEpbkSvgu50JkOXgXedS/FLC2sHAyWKBWfuwL0/P9+qcMMw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Thu, 12 Feb 2026 16:12:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcm3onha9BQEHE3UKvQ02zO96nTrV/I0IAgAAaJwA=
- Thread-topic: [PATCH v2 04/12] xen/arm: ffa: Add FF-A 1.2 endpoint memory access descriptors
Hi Jens,
> On 12 Feb 2026, at 15:37, Jens Wiklander <jens.wiklander@xxxxxxxxxx> wrote:
>
> Hi Bertrand,
>
> On Wed, Feb 11, 2026 at 6:16 PM Bertrand Marquis
> <bertrand.marquis@xxxxxxx> wrote:
>>
>> FF-A 1.2 extends the endpoint memory access descriptor (EMAD) from
>> 16 to 32 bytes, adding implementation-defined (IMPDEF) fields and
>> reserved space. The MEM_SHARE path currently assumes the 1.1 EMAD
>> size and rejects the 1.2 layout.
>>
>> Add FF-A 1.2 EMAD support to MEM_SHARE:
>> - define ffa_mem_access_1_2 and store IMPDEF payload in ffa_shm_mem
>> - emit 1.2 EMADs to the SPMC for FF-A 1.2 guests, forwarding IMPDEF
>> - refactor header parsing into read_mem_transaction() for 1.0/1.1+
>> - detect EMAD format by mem_access_size to allow 1.1 on 1.2 guests
>>
>> Export ffa_fw_version to build memory descriptors according to the
>> firware version to relay share memory requests and remove unused offset
>
> firmware
Right,
>
>> macros.
>>
>> Functional impact: MEM_SHARE supports FF-A 1.2 EMADs.
>>
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>> ---
>> Changes since v1:
>> - export ffa_fw_version and use it to construct descriptors according to
>> firmware version
>> - remove unused offset macros
>> ---
>> xen/arch/arm/tee/ffa.c | 2 +-
>> xen/arch/arm/tee/ffa_private.h | 1 +
>> xen/arch/arm/tee/ffa_shm.c | 121 +++++++++++++++++++++++----------
>> 3 files changed, 87 insertions(+), 37 deletions(-)
>
> Looks good:
> Reviewed-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
Thanks.
Maybe that one can be fixed on commit.
Cheers
Bertrand
|
