[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/12] x86: Migrate x86_emulate/ to use cpu_vendor()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- Date: Thu, 12 Feb 2026 16:30:41 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6cDebRGkm34pd9mJO+KNI2LAX1ZOpM1ipc+be2TXkAg=; b=USx/+QD38o9C7scDj11frxeGRK7saLHpSsRcA+agMReSxIfIl3uW+PrJoyIG6xDday+/KT1YxiLUZn5YdVIqEaxBxQKC8rFP1gyIIA0L8YpzkriafI0PI5sEAUBK2OYm+dYqM9XqiWEcMCaCM/FIDd55iRhkR77+gKZ8dyl66szVTgP7DReOjfrn6l5h8Egr2glOUOnS86LxP4RAzjKF1o6ZJZnSixG/Gh1IX0PdDbERqV+3g9Ring64nkwUzTduI85P4viWEcwzItUox74YXbOfgX+pOxB9xnLVlEo7OZpHPhtjBjeAZdCoWjYvp1r72mOrfRWkwbfQszrNYBRlIA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IizX33aNwiYnphUScEe1gQw+aBVQS7jSrbAIW73Ni6ZTugtepGQ+GuBSjdcM4zCacs6etkT4/F5L/lgDedw9u+G7fpbxl0aCgQgV9pAVCCHzqgSmJMkwnndmvlAFrxNV/K8UudP++jcfHVk4ZVdSpbC21j5sqhKCAltHrdHqZ2p+9OWB5RYyMDhkS340YTtU1F6OMhvpkdYgW0elYGAbgP+fEabnxQOB/J5GrnTOgrmzT6IGlbA0Djm9oQqp/dTk2PFBzNjI6odyy1qrvxjOBq10T6ZPAXEfH4gN7jY1BHZ985KcwmnqdDAFUBwNP0AtoLvO9g38bXpaIAurjoRP0g==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 12 Feb 2026 15:30:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu Feb 12, 2026 at 12:31 PM CET, Jan Beulich wrote:
> On 06.02.2026 17:15, Alejandro Vallejo wrote:
>> ... but keep the current behaviour of using the policy vendor when
>> compiled for userspace, where cross-vendor configurations are expected.
>>
>> Not a functional change.
>>
>> Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
>
> Hmm, ...
>
>> --- a/xen/arch/x86/x86_emulate/private.h
>> +++ b/xen/arch/x86/x86_emulate/private.h
>> @@ -15,6 +15,7 @@
>> # include <xen/kernel.h>
>>
>> # include <asm/cpu-user-regs.h>
>> +# include <asm/cpufeature.h>
>> # include <asm/endbr.h>
>> # include <asm/msr-index.h>
>> # include <asm/stubs.h>
>> @@ -30,8 +31,11 @@ void BUG(void);
>> # define X86EMUL_NO_SIMD
>> # endif
>>
>> +# define x86emul_cpu(cp) ({ (void)(cp); cpu_vendor(); })
>> +
>> #else /* !__XEN__ */
>> # include "x86-emulate.h"
>> +# define x86emul_cpu(cp) ((cp)->x86_vendor)
>> #endif
>
> ... this looked familiar, yet different at the same time. It was only after
> some eyebrow raising that I noticed that patch 07/12 appears twice in the
> series, with different titles.
>
> Jan
Arg. Leftover patch in my patches folder. Please, ignore this patch, and
apologies.
Cheers,
Alejandro
|