[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen: Strip vcpu_switch_to_aarch64_mode() from PPC and RISC-V stubs




On 2/10/26 5:34 PM, Andrew Cooper wrote:
This is absolutely too much copy&paste from ARM.  All other stubs look
somewhat reasonable.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
CC: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>
CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
CC: Michal Orzel <michal.orzel@xxxxxxx>
CC: Jan Beulich <jbeulich@xxxxxxxx>
CC: Julien Grall <julien@xxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
  xen/arch/ppc/stubs.c   | 5 -----
  xen/arch/riscv/stubs.c | 5 -----
  2 files changed, 10 deletions(-)

diff --git a/xen/arch/ppc/stubs.c b/xen/arch/ppc/stubs.c
index f7f6e7ed97af..a333f06119a0 100644
--- a/xen/arch/ppc/stubs.c
+++ b/xen/arch/ppc/stubs.c
@@ -162,11 +162,6 @@ void arch_vcpu_destroy(struct vcpu *v)
      BUG_ON("unimplemented");
  }
-void vcpu_switch_to_aarch64_mode(struct vcpu *v)
-{
-    BUG_ON("unimplemented");
-}
-
  int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
  {
      BUG_ON("unimplemented");
diff --git a/xen/arch/riscv/stubs.c b/xen/arch/riscv/stubs.c
index acbfde79b5a7..d071c8b86d07 100644
--- a/xen/arch/riscv/stubs.c
+++ b/xen/arch/riscv/stubs.c
@@ -126,11 +126,6 @@ void arch_vcpu_destroy(struct vcpu *v)
      BUG_ON("unimplemented");
  }
-void vcpu_switch_to_aarch64_mode(struct vcpu *v)
-{
-    BUG_ON("unimplemented");
-}
-

These changes looks good to me:
 Reviewed-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

Thanks for cleaning it up.

~ Oleksii




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.