Re: [PATCH] x86/kconfig: Reflow the SHADOW help message

[Jan Beulich <jbeulich@xxxxxxxx>]

On 09.02.2026 11:33, Alejandro Vallejo wrote:
> Wasn't following the tab+2 spaces convention throughout the rest of the file.
> 
> Not a functional change.
> 
> Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>

Largely:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -148,20 +148,17 @@ config SHADOW_PAGING
>       default !PV_SHIM_EXCLUSIVE
>       depends on PV || HVM
>       help
> +       Shadow paging is a software alternative to hardware paging support
> +       (Intel EPT, AMD NPT).
>  
> -          Shadow paging is a software alternative to hardware paging support
> -          (Intel EPT, AMD NPT).
> +       It is required for:
> +       * Running HVM guests on hardware lacking hardware paging support
> +         (First-generation Intel VT-x or AMD SVM).
> +       * Live migration of PV guests.
> +       * L1TF sidechannel mitigation for PV guests.
>  
> -          It is required for:
> -            * Running HVM guests on hardware lacking hardware paging support
> -              (First-generation Intel VT-x or AMD SVM).
> -            * Live migration of PV guests.
> -            * L1TF sidechannel mitigation for PV guests.
> -
> -          Under a small number of specific workloads, shadow paging may be
> -          deliberately used as a performance optimisation.
> -
> -          If unsure, say Y.

I'm trying to establish (among the committers) whether we're indeed meaning
to drop this sentence from Kconfig help texts that we touch. If I wouldn't
get conclusive feedback, I'd likely put it back in.

Jan

> +       Under a small number of specific workloads, shadow paging may be
> +       deliberately used as a performance optimisation.
>  
>  config PAGING
>       def_bool HVM || SHADOW_PAGING
> 
> base-commit: 1ee8b11c1106dca6b8fe0d54c0e79146bb6545f0