Re: [PATCH v5] xen: Add Darwin.mk

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Feb 09, 2026 at 01:42:05PM +0000, Bertrand Marquis wrote:
> 
> 
> > On 9 Feb 2026, at 14:39, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
> > 
> > On Mon, Feb 09, 2026 at 01:33:13PM +0000, Bertrand Marquis wrote:
> >> Hi Roger
> >> 
> >>> On 9 Feb 2026, at 14:26, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
> >>> 
> >>> On Mon, Feb 09, 2026 at 11:46:44AM +0100, Bertrand Marquis wrote:
> >>>> Xen does not provide a Darwin build configuration useable on Mac OS.
> >>>> It is possible to build Xen Hypervisor (tools are not supported) with a
> >>>> toolchain able to produce ELF binaries (GCC or others).
> >>>> 
> >>>> Add config/Darwin.mk to include StdGNU.mk and force
> >>>> XEN_COMPILE_ARCH=unknown, ensuring Darwin builds always follow
> >>>> the cross-compile path so compiling on Mac OS is always handled as a
> >>>> cross compilation case.
> >>>> 
> >>>> Only compiling the hypervisor has been tested !
> >>>> 
> >>>> An example of how to build the hypervisor for arm64 on Mac OS
> >>>> (tools cannot be build for now) using a compiler from brew:
> >>>> - brew install aarch64-elf-gcc aarch64-elf-binutils
> >>>> - make XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-elf- HOSTCC=clang
> >>> 
> >>> This needs 'xen' target passed.
> >> 
> >> Without any target, xen is built by default so i kept the simplest 
> >> possible command
> >> But I am ok with adding xen
> > 
> > With the `cd xen` omitted, won't that also attempt to build the tools
> > then?
> 
> This is supposed to be called in the xen sub-directory not in the main 
> directory.
> 
> Now i get why you wanted the xen (and hence why there was the cd xen before)
> 
> Maybe having -C xen would be a better idea, building from main Makefile could
> bring other side effects i guess.

I don't have a strong opinion, both -C xen or xen seem to work for me.

Thanks, Roger.