[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2 2/7] xen/console: use bool as return value from printk_ratelimit()


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: dmukhin@xxxxxxxx
  • Date: Fri, 6 Feb 2026 12:24:19 -0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 148.163.138.245) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PAb5O/Y8tkJMuRffwwSmk6ToGXwlAAsbstwG7rcOOjk=; b=sbUnvvVlyO2RJoEKeYDmILQJTD1iptz7LzZhGxaajQQvQQG3YS1bLs8zh04X1Ji/0kHDrP39HfDphRGehnhOF73U1n5hu6sRJI+wB6TPstyR9RbooKV6vt4tCGKtXHztkOoH3iCLV/99Q0sGIlxtudwqeHFCBNejWlYwNVfN5Ecq4V/pPFDdir3JDJtFo/ydex9MTF5BnW1P0IGba5yJITdN55b+0i7E02lycR63FdUmXXnBohxYoWUUuOQCs24nVOIE35UHErVFtV2Hn0d2qzECdVIvrLNfvEjDsTGxiwNCq2aoB45XAUOPKdTkjQZEv+OGtA2a8TL7UVos7dkQSw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lysWj6+PYXB8dooueUFWKNAqa0zV3U58ab4+nI3XNoEOigkBU5V9KJFa0aDA90uUcaZjQi8T6CqXldaUU6d3CnCjkTBi8LhPyM5PB56WsPW/AiomBXePpP7Jpol56lr9k5yrjyhTuwElV9LhdauWe9aLncvY67/eC1l1VGCjWqdD0Bsi62jQ2f/CuhBHEZHLt2vR1mIvkuBRBwConi+DABEm0f9MI/TgNpalaQ0NiV6t/8SJv1zqrcnYTabVJXktZgryqyzMxYESOQIjX1/bMbOwEecrfURVhtuOKMHKo5GtygVrgq9lEgdc60PIYrsVU/3FK4vX2vjbxS33LQhAJQ==
  • Cc: andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, jbeulich@xxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, dmukhin@xxxxxxxx
  • Delivery-date: Fri, 06 Feb 2026 20:24:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Pser-m365-app: SER-APP

From: Denis Mukhin <dmukhin@xxxxxxxx> 

{do_,}printk_ratelimit() are predicates. Make that pronounced by updating the
return value to boolean.

Not a functional change.

Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
---
Changes since v1:
- new patch
---
 xen/drivers/char/console.c | 10 +++++-----
 xen/include/xen/lib.h      |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index af9ed38da553..c4c92e3efa39 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -1273,8 +1273,8 @@ void console_end_sync(void)
  * This enforces a rate limit: not more than one kernel message
  * every printk_ratelimit_ms (millisecs).
  */
-static int do_printk_ratelimit(unsigned int ratelimit_ms,
-                               unsigned int ratelimit_burst)
+static bool do_printk_ratelimit(unsigned int ratelimit_ms,
+                                unsigned int ratelimit_burst)
 {
     static DEFINE_SPINLOCK(ratelimit_lock);
     static unsigned long toks = 10 * 5 * 1000;
@@ -1313,11 +1313,11 @@ static int do_printk_ratelimit(unsigned int 
ratelimit_ms,
             rspin_unlock(&console_lock);
         }
         local_irq_restore(flags);
-        return 1;
+        return true;
     }
     missed++;
     spin_unlock_irqrestore(&ratelimit_lock, flags);
-    return 0;
+    return false;
 }
 
 /* Minimum time in ms between messages */
@@ -1326,7 +1326,7 @@ static const unsigned int printk_ratelimit_ms = 5 * 1000;
 /* Number of messages we send before ratelimiting */
 static const unsigned int printk_ratelimit_burst = 10;
 
-int printk_ratelimit(void)
+bool printk_ratelimit(void)
 {
     return do_printk_ratelimit(printk_ratelimit_ms, printk_ratelimit_burst);
 }
diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h
index f516215ca8e4..e39fa9200c82 100644
--- a/xen/include/xen/lib.h
+++ b/xen/include/xen/lib.h
@@ -82,7 +82,7 @@ extern void guest_printk(const struct domain *d, const char 
*fmt, ...)
     __attribute__ ((format (printf, 2, 3)));
 extern void noreturn panic(const char *fmt, ...)
     __attribute__ ((format (printf, 1, 2)));
-extern int printk_ratelimit(void);
+extern bool printk_ratelimit(void);
 
 #define gprintk(lvl, fmt, args...) \
     printk(XENLOG_GUEST lvl "%pv " fmt, current, ## args)
-- 
2.52.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.