[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] xen: Add Darwin.mk for GNU toolchains
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 6 Feb 2026 15:02:02 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=suse.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dnKYQMeDVtJmn4VMa68DYKnindDHzlMgDeE5Va9Lw5g=; b=HzhmYGlOxUe56N/0LZc9okJI50DJE7CYBggPeAImRV2k9V7pHkbBnPgUi//ngcPqjVA9fNTybyyhH5mi/yIqyrDP2kzhUz9KMKGbxZ1Lx6Q8tZavMir3IOacEoNirke+tEtFY0CVF2PXKf0hblkhXMqVmc4yI365NLlHYoG8yNYDPmMnS3kGJtbRY6dz+OM+U6fTPztbm6wqSHuXKA+mEOSZxqmQQaCf/cgrOVTJIhnit4JRGBvUarY9Ku41zKy+cSH5cgkLKRU540M5SHHL8sW8mdi3zZ1TL7RCLXuLhbDyNJpkDHzezq/0g+HIrUPELj1RgWRrt1cUd8Yz5+CJLw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dnKYQMeDVtJmn4VMa68DYKnindDHzlMgDeE5Va9Lw5g=; b=KTzvYFvlxWjobdf6BrRKJDRj8ZQYd79ZRRNqCY06tsuKYYLXzeg2QYinLcwAsJAwBuUXwUkvX93xWm+fsUgTYATIpW2Cnekpwg+Y/A2UalSXuZR4xqfyeukz6OwNP9ZrJQEUqarnnAN492uhSOyH7VrCH7VVjQC2+w4fyTTSdR6UN7IRkXG/COkcFNT4H+FIKYISCNW8VTS2exn5fsrnxn55HPiAP3MlaXVeApv+30OejdQEWzue9I3B3naNjJv6Y755kzE8AynewftXPkLaKYkaXd3cQ+d/KV3LX1GGBDKIDKnSDHSiL0GFX5nUueKiBhYjXyykVQ249O2xsqvrSg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=B1xPGy8gWwBBSIsoo2WadZKCyPQUMIrroAWaEG8mjojkm6AqEjAiL+Ti2XZaCJm9HxbM/nJ/eQ2YqVdLDnoeAZMpjGxdHRRL1/oa42t+xfbexbqsx7QsEySc+E2cB4lA+qYb/Y1N+0fVbVukp5XWwrTM2Xx2JdcE04AGhdZso55tufSoxCtkYBLAmEJR/SAHfvN9gzfP2lulNraWgtt9gloea1oyaqCfpvzA/9RPy98zBliYJoJ4JHm41/KY2BDwpLkyLmsrvwW8Y4wS0C2vsSulARzL8CCm7QL6nMu6pGOPHcUJyvNqNErxC3DZnb83plCtBAnho8+JZjr5gM+IrA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KOOmUXnbadggPfcjCAtagM46rwgMVH/ooAm4ur3aggDWxiJHjp1O6TLAD9Gh/BGjTOuzYJgnb2F6g+fzH1gGSgq88kLU15Z2KuLTG7aFHKP2zCgyrMat+Vp5RQsygyQPey4P+77iLAEjefRWYffPITPu4Q9JKmq7N2hpSMqKDRI1k5AEZwoaUd6YJFoz5bMzYbmEHktYlcFyuLIiLwWprrat9z86UFh98ERk5CjWu49PNNC7eoSCGCTAfkb3XjRpEb1wiBF/aZAdtT5GWB6kVZhXThmKkUqA2XT2qrR7f2iSFUKQfIXZO5zJIvRVjlgTeWj+jW2U21iFl6fU9ZZ0Zw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 06 Feb 2026 15:03:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcl0ETIV6m5wqgrECh60MWgPTuGLV1etQAgAAv7QCAAAFMgIAAGAqAgAAAdAA=
- Thread-topic: [PATCH v3] xen: Add Darwin.mk for GNU toolchains
Hi Jan,
> On 6 Feb 2026, at 16:00, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 06.02.2026 14:34, Bertrand Marquis wrote:
>>> On 6 Feb 2026, at 14:29, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
>>> On Fri, Feb 06, 2026 at 11:38:02AM +0100, Jan Beulich wrote:
>>>> On 06.02.2026 09:17, Bertrand Marquis wrote:
>>>>> --- /dev/null
>>>>> +++ b/config/Darwin.mk
>>>>> @@ -0,0 +1,7 @@
>>>>> +# Use GNU tool definitions as the tools we are using are either GNU
>>>>> compatible
>>>>> +# or we only use features which are supported on Mac OS.
>>>>> +include $(XEN_ROOT)/config/StdGNU.mk
>>>>> +
>>>>> +# Xen uses Linux'es ABI so we are cross compiling on Mac OS.
>>>>> +# Force COMPILE_ARCH to a fake value to make sure it is always the case.
>>>>> +XEN_COMPILE_ARCH = Darwin
>>>>
>>>> I first wondered why you say "fake", seeing the file is named Darwin.mk.
>>>> But
>>>> in Config.mk's cross-compile check the build host OS doesn't even matter.
>>>> So
>>>> yes, it needs faking here for the time being.
>>>
>>> Hm, setting it to "Darwin" seems weird to me. I understand the
>>> purpose of this is to force the user to set XEN_TARGET_ARCH
>>> explicitly. I however wouldn't see it as fully uncorrect to not set
>>> this. It will then execute `uname -m` and get `arm64` back for Apple
>>> silicon macs (which is kind of OK?). Other I suggest we use a non-OSX
>>> specific value here, so that if required we could distinguish this
>>> case where the user is expected to provide XEN_COMPILE_ARCH.
>>>
>>> Maybe XEN_COMPILE_ARCH = { unknown | undefined }?
>>
>> I am ok to change this with either but maybe unsupported could be
>> a third choice?
>
> If I ran into "unsupported" there, I'd wonder if I even should trust any of
> this and try it out. I'd prefer either of Roger's suggestions, in the order
> given.
unknown it is.
works for me
Cheers
Bertrand
>
> Jan
|
