[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: use BSD sed compatible regexp in SRCARCH
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Thu, 5 Feb 2026 15:21:29 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=suse.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cJxYP8Z+yZ6wCzrr0ORTtdyUimwFteTYhoYHE1xRPdM=; b=yB7dYCyP5e3nwl1BdA6d2/prMcZMGPl7qYuzprFmyGGQgls4e3DbSV39+7K8ZosyObSPpQcnQaOfyhwLbONXlTCCAYYmPRqkixxV5wvOA93RjdVzolIlMd9GvDYKB70hn3ipsqEXfH4kBuHcgA7gjQdmBn4ETWfP7d47Ep1Hf5rYnU/2+kxftqjogRmyD/untlZdFtv1ZI4/qvpiDNMUBroi7Amv2G8lsP5somWgJQlSJHufb+MjlpUPYs7IpGnOneDZczUByoBw0ka5HR8UZHwg69XLAIBRFCDtscLcWkjTvhTkmBvqV77nJHRMKAppSNzx77VTYfYYZ5n6J51ANg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cJxYP8Z+yZ6wCzrr0ORTtdyUimwFteTYhoYHE1xRPdM=; b=CEzc7LpUY4WJHnaYuSnAOn78LdUdOx12mxkRE8xfScHbm67zWI4pgolkBH6cDAeY8xWyYcx/PLBy7Niv4X2xUNWKDYWae6SL3yr9fJdKVNEyxadvM1/sZIC9U0hqR0/yBB97FiKqw6myFTyORR7JWJ0zzPgNTshpcAZ96iUfT+eFQCU+vYCOraP5dkxlP3Ouh+zlngGOK1CRe44RWlQlvL49jqQS+bLDTKww77AHOrPBUMXQIWjPHeHLUF3RE+XxUFRqZu5ySoVvNRW9XvFR7x9CZMqXMOYl2jZQjlqQjidyVndxBm4xT982eC3JgFQpIglPml5cqCIad18eqJyZaA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=ilIwo6X5a0p5o9sLT655X27iI7v4c3xJlMBQJm7O0c3W2utZUKVdKH0HtUxz5izlqa8H3S66pdbXZElrr7TVVXSIZPzDXyWQoSajoTVojfI6DtNmB71PdIS07qfrIPFafgjgFF8QetXrLRRgsYXd+tPhokJ+SQT5Ff4XD/ZFn9rxlLpzriHng5HGTs1y6flesG0ACvlNwVr+6QyXvfBp/M1m/KwcNh41B5FyXZHihJshspfKxDOpQx7uhRPo6obVzj/IJBFGszUmo0o/rvlPWMH5D17yCinp23GNJAw0mPBq8ct5Pr0TUJ8pgyxvsL7IUT43txPW7mb5FOza4yUIWg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bycO4cGyeLpf+mtPR3gTnAEtB6MgckVGsdZ/2wK0Z4LJlSUYGDt8BnawCQ8JOfDCouQXJjjRskU/Zg4Ws80F1dHwH31XJzYyRibkkDzYVAGwrvYtqOLIqq0Fsv7/HONpNsdIXDLcB9VG/d7U99PlYzXKWbQ8wCY4YXbNtGa8qdyePYhmR8D8nc9KSpFh3FTPZ2qJ9emzMWd1M88sNsBqxFUJR277avP3FpGsu516V+3krkU8ndYYVCS+0zCuQ5fqcEH7ZaBBVi+secaD766eZmUClJ0D1LZnDQxfG8w2bfbiXTsOo7kGACqbSRf4wxiFXJEuCq6jhikLtgQdfFK4Eg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 05 Feb 2026 15:22:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHclrAVmOqVSx0X9U6hX+RPaUIqwrV0NaIAgAADJYA=
- Thread-topic: [PATCH] xen/arm: use BSD sed compatible regexp in SRCARCH
Hi Jan and Roger
> On 5 Feb 2026, at 16:10, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 05.02.2026 15:59, Roger Pau Monne wrote:
>> Convert the ARM SRCARCH variable setting to use the more common 'arm.*'
>> expression rather 'arm\(32\|64\)', as the later doesn't work with BSD sed
>> for not being a basic regular expression. The usage of | alternations is
>> not part of basic regexp support.
>>
>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Tested on mac os with mac sed and works :-)
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>> ---
>> xen/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/Makefile b/xen/Makefile
>> index 13e336ba5484..31352d4cd260 100644
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -242,7 +242,7 @@ include $(XEN_ROOT)/Config.mk
>>
>> ARCH := $(XEN_TARGET_ARCH)
>> SRCARCH := $(shell echo $(ARCH) | \
>> - sed -e 's/x86.*/x86/' -e 's/arm\(32\|64\)/arm/g' \
>> + sed -e 's/x86.*/x86/' -e 's/arm.*/arm/g' \
>
> Perhaps to guard against something like armv7, use arm[36][24] ?
This is the target ARCH in xen so we only support arm32 and arm64 so
this is probably not needed here.
At then we just want to get the main arch, so whatever is after arm still
means it is arm so i think Roger's fix is good.
Cheers
Bertrand
>
> Jan
|
