[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] xen: Add macOS hypervisor build support
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 4 Feb 2026 15:45:33 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=suse.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8FFbh+npZy9Vu52M0Se5EutoZFbtw1TYlWHYunbpRME=; b=ZWDaT9pAlT3kQnzOPWNb7sphxKwg/QSniAd8bnxOQivFEvoEWyZWuox/Lyxvp0fB11fBXPRZpeOMAvnpcrq8TX5lKaBJE2Z5MDJ+CYueUH+0qE8PzMyxtrDLEmLawjPJBeWPJ+JdH7K1Eq7TrbBi/RMs2NfrUYF5nGrAU1xkmpgLmIcyOoig//HZc3/C+MZ0T7Nc7xuISwX4hnt4mOKcIYhRy3rgq+taqnC2lQFjtXIEWpBH7j09mqVrX1Gs3WsL9EXhhGaWkHV0EDsNVnUP+0gbRPNosLVSBVoaTLtv1e/4BFNpuBmgwMkbPA/HGNHbbewgykF/LPgFW9EigRwjvg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8FFbh+npZy9Vu52M0Se5EutoZFbtw1TYlWHYunbpRME=; b=elAnTp8pjaq9VWCcwdsoPVytJ9jVocdgnl8sm5DVl9OZxTCmnvpsAS40SrxD6Lo03SBErmzRaJO+1/8P2sP9uX7TMD8JOOMcWHUtva9Q7p80NmeVFldo2PSsaDJAhQCR9FpLBycuJahB14LHmXKULgRUpVv4nXVuOFnQDa+9hcdyX5+nYbfs3An4yd7Ml/IgPHtbxZ+K4ijlWFpB2vAROKenbqGblp9tgVlR2/0DUF/rVqvuDoCpMZ0xKv8Mf38+IKVB8qNNt08K8M983u9jGME1ZVBe7lRMkmscjnQikzVu5wIymXI/VXoQO1RkGEliCxe5e16+FD4qbCQ4FFbUyw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=Sr3mDDa9abJJqnZR/hAC2ID0kuOg/hvw1jaX62rR7TbSkcDgZq6yyKkPZGUFQ/hRlzdxYo1IA6dVQcpZCWga8d8+R88r8b/ccIVIl6yJLrFGPvCYbjwPcYN8MQbM0lyX4A6/wn1LtqKYnjRzKGTKj6ujzmMHuSbIWhmqHRkY0SRN4hJfSoiXwCefkenYAszgdMb5+pe8rtot5V+joWjT+Nnzi2NjrIV95ihJFlD1VfO48EhLtogN/y9AnNNPOChfX6wsMLAoPGbIfSYdCzviaRHdySpbHQvtyhAeyRDlAE5WMMCJw9xLzvssNHXXS/hcXuYoVgxGQl9bYLZx77xzfg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gOmD38a4vmLdH75a+y79hAaVbdrZBn3VBpyx9Dy1/nVS70Fy1NLMZpzGDPnQdPI59WibtjD1TPh+IoM5XHPdJoWh2oL3zt3a8NKKOenAU+QH+KpBUpCNrQzGNYL8rb7AwZCUfw/bpPCFTiYe6pvc5qfx69ljSWqhq1kRqVn9eFhK3VdLerl2q7lRCldrwv3JbRl+CrKN4sde5wqGFXCqA6eXvWDdHP/drXxFc32Yr8kx0JHquDjwdil0zjYQh52TB2InQprO/rC/QQmf/4DPhqJF7Vhhy4dwZp0f001+xB4WkeY5BHZ34400CwXyXuCKZtCJ1PhOpaiwgcvxYeMHWA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 04 Feb 2026 15:47:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcldiTYCc32vRyb0mp6O53Aox8PLVyquQAgAAD9QA=
- Thread-topic: [RFC PATCH] xen: Add macOS hypervisor build support
Hi Jan,
> On 4 Feb 2026, at 16:31, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 04.02.2026 14:16, Bertrand Marquis wrote:
>> Xen does not currently document how to build the hypervisor on macOS, and
>> there is no Darwin configuration for a Homebrew-based toolchain. In
>> addition, the Makefile silent-mode detection can be tripped by -I paths
>> that contain an "s", which hides build commands unexpectedly.
>
> This wants submitting as a standalone fix, so it can be backported. But see
> also below. I don't, however, understand how -I could be useful here - our
> build system is self-contained, so any include directives used should be
> satisfiable without any -I.
This is added automatically inside our Makefile if you build out of tree:
MAKEFLAGS += --include-dir=$(abs_srctree)
which ends up being -Ixxx when tested.
I was not thinking as this being a candidate for backport as the only
consequence is that if you have a s in the full path to the xen tree your
build will be silent even if you pass V=1 or Q= to make but things will
still build.
But i will split that as a standalone patch.
>
>> --- /dev/null
>> +++ b/config/Darwin.mk
>> @@ -0,0 +1,4 @@
>> +include $(XEN_ROOT)/config/StdGNU.mk
>
> Darwin isn't really a GNU environment, is it? The definitions in that file
> may be suitable, but perhaps a brief comment is warranted?
Yes this is only valid because we use brew in that case.
I will add a comment.
>
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -116,7 +116,7 @@ endif
>> # If the user is running make -s (silent mode), suppress echoing of
>> # commands
>>
>> -ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),)
>> +ifneq ($(findstring s,$(firstword $(MAKEFLAGS))),)
>
> While probably this would do, assuming make isn't going to make drastic
> changes to how $(MAKEFLAGS) is set up, how about
>
> -ifneq ($(findstring s,$(filter-out -%,$(MAKEFLAGS))),)
>
> instead?
Yes this is a solution that should work to, making the assumption that short
arguments are kept at the beginning like they are now is possibly to strong.
I will test and check that and submit submit 2 independent patches.
Cheers
Bertrand
>
> Jan
|
