[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 16/19] arm/gic: Fix LR group handling for GICv4
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
- Date: Mon, 2 Feb 2026 16:14:43 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xpG0vAG8e6xad23pmIjhAdmaEHtng9kYL4aNQEOXKOI=; b=BZVoNtoyCYEZ2o1QinhknwRcqYO5DVx1RuSnTrz8AU53ZxTalm7xpwa9O9qTwI0GO9Uj4U0cPGTqQeggL8P2MH8wtegFkfwdUtsMgoL3gLprdJbvc92z6sWCFNG8GcmOAjL0ff5WA1cKy6F0MCPA2c8XwulLqsnKHEZ65yYTg6lQyoB7onRbq0IXk5a+QbOwUqZ9vmJnf4D3J/z5KI9/MHrJ9MtmVyKcaYLTpaSFwuwNIDOwLqsnmkIMsaRDmiGesVGMbByfUAmHXaJtkq874CcN6SJtzYaoNrviHzOmcy7CWNsHSHdkYb38sf5h4gP2vkB5HUbDPYC3cfihJqwemA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PZFwqLP8jnAX3vL533jFRxDiixPUBW2I/QRHrFwYd9qqpzalhNpjeYhXYGWrcGmuJUWz+toKCq/mbF2qkz0n9ITyIrZadbY4OTvmG/tNcEu2DQQFgnux7rmSp9yT4S/BOk9HSk8b/Z8ZCwI0DkNLfmTz4OJ5M2+QeF2CANSqZ0BiFw4MZSTAiaEw/lRShgP5RTHym8sfhznHZ3YvkDrzKTdiwMK1dF+JTiU4GwnmBxlawBPH43JwNJaSOd4R/885eh53byFsLjBtObUN4ZKzNEFI6qBwnMgdQDPFGfwlKW8Iugdg4HMCE2EfSUU22xatwPKRxJsgpNtxCsz2dMFPmg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: "xakep.amatop@xxxxxxxxx" <xakep.amatop@xxxxxxxxx>, Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 02 Feb 2026 16:17:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHclF8K603U0XXQOEuJhQnegCFT+Q==
- Thread-topic: [RFC PATCH 16/19] arm/gic: Fix LR group handling for GICv4
Extend the check to mark interrupts as Group1 for all GIC versions >= 3
Signed-off-by: Mykyta Poturai <mykyta_poturai@xxxxxxxx>
---
xen/arch/arm/gic-v3.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 07736179db..1cb3169b72 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -1366,10 +1366,10 @@ static void gicv3_update_lr(int lr, unsigned int virq,
uint8_t priority,
val = (((uint64_t)state & 0x3) << ICH_LR_STATE_SHIFT);
/*
- * When the guest is GICv3, all guest IRQs are Group 1, as Group0
- * would result in a FIQ in the guest, which it wouldn't expect
+ * When the guest is GICv3/GICv4/GICv4.1, all guest IRQs are Group 1, as
+ * Group0 would result in a FIQ in the guest, which it wouldn't expect
*/
- if ( current->domain->arch.vgic.version == GIC_V3 )
+ if ( current->domain->arch.vgic.version >= GIC_V3 )
val |= ICH_LR_GRP1;
val |= (uint64_t)priority << ICH_LR_PRIORITY_SHIFT;
@@ -1455,10 +1455,10 @@ static void gicv3_write_lr(int lr, const struct gic_lr
*lr_reg)
}
/*
- * When the guest is using vGICv3, all the IRQs are Group 1. Group 0
- * would result in a FIQ, which will not be expected by the guest OS.
+ * When the guest is using vGICv3/vGICv4/vGICv4.1, all the IRQs are Group
1.
+ * Group 0 would result in a FIQ, which will not be expected by the guest
OS.
*/
- if ( vgic_version == GIC_V3 )
+ if ( vgic_version >= GIC_V3 )
lrv |= ICH_LR_GRP1;
gicv3_ich_write_lr(lr, lrv);
--
2.51.2
|
