[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/6] PCI: determine whether a device has extended config space
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 2 Feb 2026 10:21:19 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=znUDnci0R8WKNobrONWueMov6XMO8k+67w/JNfIRzUw=; b=ln6lQORKyLLlC8ON1KMv6LAmVa587JakbBp0O1IekVcda5ZwtHhdYl9MZLH4e8CN52sRWC4mXi72/qo6EN5U9CwtOpdx8aY2qFcFaqO1MwbHVUtD636h7giU60otT7iztJxbcZOTP3gzUoG+yQj1ztaLgezMvoDjFQvRXbjgNMk9Hr0y+IFK2A9pJmUBvSoNQ8E/xRKSUuBj4O6WPZ0M6KnPjCtlbceHtOHt9JVr9e1wOp1/ZqNoJPQ9p4UqLj7UFyOuVRghLZVjRTEB3204DDlQWxkctcVZvbNz3EdfIJkskDQTNjEY/SVjAmjHm3mnQ25L4LSzufKp37jCCJDtQA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g4aAjPuWqmX5H3tmul9S+UUCij59WEX7jTi/FAfPQSoyjlUVFBRws3ONkwMydqZSj1TJyd0WmFxoAha+hmiYHThePmPWp9OPJzk9Tv9yQdQkonzJEZSPyGFppJPY0nCIUe28TCuXAUHFxsYaftIkcZEhNrE0oFVZDQep3AxT/IgT9sC0IqmWKzovZAz0a4C19TN55y9jyU+Ko69SViZMBOaDToLulMZtvc5NyyRwOwLU39Y/YOh3l3DgIuSUl800N0ic6tW/X1iLBV0H9pyI6PD6nJHBoQBSszdv8785tu/VkQ6hDf9aBQY/dCUYDhFOqFA89AUj6TYVgbdngzozVg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Delivery-date: Mon, 02 Feb 2026 09:21:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Feb 02, 2026 at 10:14:57AM +0100, Jan Beulich wrote:
> On 29.01.2026 14:08, Jan Beulich wrote:
> > @@ -1042,6 +1053,79 @@ enum pdev_type pdev_type(u16 seg, u8 bus
> > return pos ? DEV_TYPE_PCIe_ENDPOINT : DEV_TYPE_PCI;
> > }
> >
> > +void pci_check_extcfg(struct pci_dev *pdev)
> > +{
> > + unsigned int pos;
> > +
> > + pdev->ext_cfg = false;
> > +
> > + switch ( pdev->type )
> > + {
> > + case DEV_TYPE_PCIe_ENDPOINT:
> > + case DEV_TYPE_PCIe_BRIDGE:
> > + case DEV_TYPE_PCI_HOST_BRIDGE:
> > + case DEV_TYPE_PCIe2PCI_BRIDGE:
> > + case DEV_TYPE_PCI2PCIe_BRIDGE:
> > + break;
> > +
> > + case DEV_TYPE_LEGACY_PCI_BRIDGE:
> > + case DEV_TYPE_PCI:
> > + pos = pci_find_cap_offset(pdev->sbdf, PCI_CAP_ID_PCIX);
> > + if ( !pos ||
> > + !(pci_conf_read32(pdev->sbdf, pos + PCI_X_STATUS) &
> > + (PCI_X_STATUS_266MHZ | PCI_X_STATUS_533MHZ)) )
>
> To not violate Misra rule 7.2 I'll fold in the change below. I guess I'll
> further follow up with a patch adjusting other problematic #define-s in
> that header, too.
I'm fine if you want to do a pre-patch fixing all the problematic
defines in the header and put it ahead of the series. Maybe it makes
more sense to fix them all in a single commit than fixing one here and
the rest separately?
Thanks, Roger.
|
