[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 4/6] xen/p2m: move xenmem_access_to_p2m_access() to common p2m.c


  • To: Penny Zheng <Penny.Zheng@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Thu, 15 Jan 2026 10:08:15 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AT0YncTFlrxicix8PIWQyUS6zwBdKYeczTKCyPIeycY=; b=hoFVyBm1FjIgvLf8HGFLtbAX2KgHlMakLrFNOO6zgZXV3Y8d08yJPWBGkLSblt+h3JAqZXAzcvjw0N84+lUwMo2SoSoiskV4vI8FdgOlPyENY+oLApexrVNVjYxdbVDc5fvq5GwR7XaKdAat/c9dB+JH0b5NuHVw9vXLR+x7iH7EMV51QjkK2L3+PE9Ha3Qt+ydRml1/kXo+fAQMwIzZfoB2157oBDNRZajKGtDthFyXB4u84jHrOhrCQvmg+bgN3eGESKYovKTVd/ESpwa4Fj3bEAT3eZhR0Ejm+obno6jc4xU1MWe/DY1yxt/zod2WQzoosrjROgqPvpHmVmBy+w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p3/aiv0CjILA943Oe+m+0rNs994WoeGGaaNTid+VM8aIBfXGVknLop+NqX64UFDIrEAzF3tf7LU7L8MHkyHOE1E1AMTbyKYfrYP4zb1pyhotQrgDoMfKBDKA5d+oL06Sxj0nL1tIyGffvj8PzSIL1oJ5zzapKjPnG9E5BASdU2yWM3iDdlgU6U4/Zoc/QZXm8AZgAA1WU6FsoBsI4djPlLUCFjUgnnIY58TZRWSvfW5l6H+U/F3a8Cc1LZb2A1wb1bEY9+AjGEYsmDBPozddBb4xGMcCnriDoDZxyRrvocwCwTC24dj4Va+topPblikGxACJa1rSmBbotgEtGzMyVQ==
  • Cc: <ray.huang@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, "Alexandru Isaila" <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Michal Orzel" <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>
  • Delivery-date: Thu, 15 Jan 2026 15:21:03 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2026-01-15 04:28, Penny Zheng wrote:
Memory access and ALTP2M are two seperate features, while both depending on
helper xenmem_access_to_p2m_access(). So it betters lives in common p2m.c,
other than mem_access.c which will be compiled out when VM_EVENT=n && ALTP2M=y.
Guard xenmem_access_to_p2m_access() with VM_EVENT || ALTP2M, otherwise it
will become unreachable when both VM_EVENT=n and ALTP2M=n, and hence
violating Misra rule 2.1
We also need to move declaration from mem_access.h to p2m-common.h
An extra blank line is inserted after each case-block to correct coding
style at the same time.

Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.