[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/6] x86/cpu-policy: define bits of leaf 6
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Wed, 14 Jan 2026 13:49:30 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a2rXE0xpYpVD/5RkoyymIGKvNPcJ6yv8N6AT813fJ6Y=; b=rjqxapGGu/roOQv9b33xbMFwS82UT1f/1QuZQn74XTsiN1a+Bg2XOEd3hsbtka/dKCv56HxZcJTzkAW/Yv9W+3IWYJpvQJ2z6PEomNnIeuaeHz9szRu24+djJQtV4g98WFVikmJquF88DpIDAy2c86eRret647FAERZ7Sy6QWj3TWALmXDvXbdAgFsrgD5WRKxapN97Tib8dJ+OEjXPNE9WgKfXTI6DXHxqrFCwfyHDB6okCKKIYlGucP1kshI7sQ1zJwPhpq/mWmtN/h3cut3mocH897XIoLGEUdfDxinxIc+ZVA7wEspAUjyaWAAM+h+pjbbhlCgtIEXpgbE08og==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QsHPCVNKPJUv8EgEs140Q5sty5bIgUnGTe5T7O6NIiV2Kwe254H/sJETPko92Gpk3raODD61Jfj+a23eWE9i8Zt1aUwSDKxVr7DH4RrTd8yk3ARuVkTMazJqz4zRt58u+WHuVZiHVoMTs4fnaEcjsetZTN4R6VW8NqQ5k9J9xBcFL3me8if+7Qu9aQLN9cYOyMnbPeYDtuTOVKbS8mxpQvI0fefzHNJWw03D8xP9zG5La+UouHdIGyjTKt6G6kC+lJ0qmj0ormms754OAxOk/srfcWTe4Wep5Kpy1ffHxoyxkfW8JTU2hu/iCVSQW4SK9AVbX/zw0A5oaMr2JuYe7w==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
- Delivery-date: Wed, 14 Jan 2026 18:49:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-01-14 08:43, Jan Beulich wrote:
... as far as we presently use them in the codebase.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
+ /* Leaf 0x6 - Therm/Perf. */
+ union {
+ uint32_t _6a;
+ struct {
+ bool :1,
+ hw_feedback:1;
+ };
+ union {
+ uint32_t _6c;
+ struct {
+ bool hw_feedback_cap:1;
Maybe with an comment of "/* aperf/mperf */" since that is probably how
it is better know? I was confused with hw_feedback above which is
different.
Actually, looking at patch 2, I'd prefer leaving this named aperfmperf.
While not the SDM name, I think it's a more common name for the feature.
Either way (but preferably with aperfmperf):
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Regards,
Jason
|
