[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/platform: adjust CONFIG_VIDEO usage
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 13 Jan 2026 14:40:47 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n4uE4TuaosuHx1ZcfmsmJ7OxEFtfON5KHQSsae2zFmE=; b=qnp5L1q9fc3e7cgH760P6wpwbcX8sDWJe8jWauSUEmkybvwkV6Hsnsm97DQRZZyMmPce8A1qskAsPELy8yu1Kvxi89CiiYQviXhllDMBVCSBL64tqdmi4R5RsHy8RK+XDX6/Ex3cealuv8clXjEoWM99e7yIFeLoJA1081mJGobh7qR7uUS2s/y8F0YRY8JQNfWGCfIibb5f1/XMGuXsQYD/wqFdqReO5PulbrOu1OZrUORLplrMBH7na3RvLG8pku0egSa0YuqEWRiJpAo4A5b3zStG6t0A3lAXeun0kbty+vc8PYA1ER+dYidZyBK2S04yQJeIfZj96qURzCAEYg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D0J0+hEZJI8/X/BpPEsMYerACWK3zSJmVXcvZFUdLhMgy4Yx41kGxf34JXbr6Bh/doS1nBkrqSttbiMvEvLdRyg+Dk00hZsP76GTr2+NH8ust5zmyYx7jLpHE3Kj3rzE/qNKfjPiOWz/kYYICV45UP5hzaJIn+unvWQKtHuoMGEeSHffI9BjE5arBX8zmpdF/PiPjwuxaEN+un8HZP1LgKPphCAN2rWREtWKR4z0cCgzCuOmO/L6oDgpPDh5NkoriIfWmljufJY+jCqqsRwpgQ72dMf6fu1+V8vkDS6EVvyb3Ah1t8NHI3MnJJbxlUpR+AqFRArpR8ptRhpYRUfLRg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 13 Jan 2026 14:40:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13/01/2026 9:23 am, Jan Beulich wrote:
> Switch to using IS_ENABLED() in both places, thus in particular making
> sure XENPF_get_dom0_console handling doesn't take the "default" path: The
> behavior better wouldn't differ between VIDEO=y and there not being VGA vs
> VIDEO=n. For this to work, fill_console_start_info() needs to be
> unconditionally declared; extend that to vga_console_info as well.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> I'm not quite certain whether to have Fixes: 11b4ff64841e ("x86/platform:
> protect XENPF_get_dom0_console if CONFIG_VIDEO not set") here. Opinions?
That's up to you. I doubt you're going to backport it, so it really
doesn't matter does it?
~Andrew
|
