Re: [PATCH v3 3/4] earlycpio: lib-ify earlycpio.c

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 13/01/2026 12:21 pm, Alejandro Vallejo wrote:
> It's only used for microcode loading on x86. By lib-ifying it we can make
> it go away automatically when microcode loading becomes an optional
> feature in follow-up patches.
>
> Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
> ---
> v3:
>   * New patch. Subsumes earlier conditionalisation of earlycpio.c on
>     CONFIG_MICROCODE_LOADING.
> ---
>  docs/misra/exclude-list.json    | 8 ++++----
>  xen/common/Makefile             | 2 +-
>  xen/lib/Makefile                | 1 +
>  xen/{common => lib}/earlycpio.c | 0
>  4 files changed, 6 insertions(+), 5 deletions(-)
>  rename xen/{common => lib}/earlycpio.c (100%)
>
> diff --git a/docs/misra/exclude-list.json b/docs/misra/exclude-list.json
> index 388397dd3b..2b874dfd3b 100644
> --- a/docs/misra/exclude-list.json
> +++ b/docs/misra/exclude-list.json
> @@ -121,10 +121,6 @@
>              "rel_path": "common/bunzip2.c",
>              "comment": "Imported from Linux, ignore for now"
>          },
> -        {
> -            "rel_path": "common/earlycpio.c",
> -            "comment": "Imported from Linux, ignore for now"
> -        },
>          {
>              "rel_path": "common/gzip/*",
>              "comment": "Imported from Linux, ignore for now"
> @@ -225,6 +221,10 @@
>              "rel_path": "include/xen/decompress.h",
>              "comment": "Imported from Linux, ignore for now"
>          },
> +        {
> +            "rel_path": "lib/earlycpio.c",
> +            "comment": "Imported from Linux, ignore for now"
> +        },
>          {
>              "rel_path": "lib/find-next-bit.c",
>              "comment": "Imported from Linux, ignore for now"

Honestly, I think this needs simply dropping.  "ignore for now" isn't
going to cut it with any competent evaluators.

By libryfing it, it's no longer part of the AMD target build, but it
does want covering by *-allcode.

Given that you noticed it for v2, I presume there's something in the
file that Eclair doesn't like?

> diff --git a/xen/common/Makefile b/xen/common/Makefile
> index 92c97d641e..4fc0c15088 100644
> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -65,7 +65,7 @@ obj-y += wait.o
>  obj-bin-y += warning.init.o
>  obj-y += xmalloc_tlsf.o
>  
> -obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma lzo 
> unlzo unlz4 unzstd earlycpio,$(n).init.o)
> +obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma lzo 
> unlzo unlz4 unzstd,$(n).init.o)
>  
>  obj-$(CONFIG_COMPAT) += $(addprefix compat/,domain.o memory.o multicall.o 
> xlat.o)
>  
> diff --git a/xen/lib/Makefile b/xen/lib/Makefile
> index efca830d92..60cfda4dfc 100644
> --- a/xen/lib/Makefile
> +++ b/xen/lib/Makefile
> @@ -3,6 +3,7 @@ obj-$(CONFIG_X86) += x86/
>  lib-y += bsearch.o
>  lib-y += ctors.o
>  lib-y += ctype.o
> +lib-y += earlycpio.o
>  lib-y += find-next-bit.o
>  lib-y += generic-ffsl.o
>  lib-y += generic-flsl.o
> diff --git a/xen/common/earlycpio.c b/xen/lib/earlycpio.c
> similarity index 100%
> rename from xen/common/earlycpio.c
> rename to xen/lib/earlycpio.c

What's wrong with .init here?  There's only a single string which will
end up unmerged so I'm not worried on this side of things, but we now
have series doing safety things getting tangled with .init and I want to
get it fixed.

~Andrew