[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/4] xen/arm: drop MAX_PAGES_PER_VCPU
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 18 Dec 2025 18:19:47 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0OdRRQa8t0+XY7qJlOwaXc1ncWpFT2D7jETm/Em3mDM=; b=KMJFe236qg+gEtY29Z9hN23bphibFJIAuj7hc8t9sbzh0OzAxFKVJtGMTa8SjZTSwqolNpRVZQLjvSVbe9FFtC1JGqMNA3C2crPtWGK+tq7hDoQ58Bl0sW6JKlOfbaspFPo8vUGkEQ+6qNjoorbjCvx7fhUpi4QMl/Q8FlLVz0DGU/F5jiNaeY1i6PN9kM6PHy4vtfediTzvdVYnGiSAFQeQ38iQ41S0qawQwyU8WkECRe4Qo1bbmqIQ3dxT0BnDsFtkM+Ivs4xcNbBaPj7fc4rN0wOuB2CW7+2hauxJyab3bts+voXLFozN99RlHRl/RN6oGBVlJr8FmpdBOydC8w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jtWvcpHi7Bnuw+zPd0MJhXAWD7dgDkCLDET0Aid+8BjTwOen/fr+cMm+8+r7I3D6+5S77CD0ZiEKx0a8P0TZ5sVeklmU/5Rnfax+1G6zJzvW0X5QudVn2DezZxpTFLaFth5aT74VVWD5zhiPAUnSIDHnwq+iYpP2qTkv1IGinCuh1AOql4WX6PX7NjaNTzAld/Uoz4KH7vclSaixim3iJpiYNJ5cb4RnP4uLlCFoiTBf5FQkAddPVgj9RZShYgSBRlJV+ZRKKDvvUzL8MUtf2gF9YrB8Oh2AiLs0xzUpVj9WYzbIsJrhkXodVXpAeHG7Wv4xH/z8s/6YsXMoGRX7RQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 18 Dec 2025 18:20:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18/12/2025 5:28 pm, Oleksii Kurochko wrote:
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 47973f99d9..e566023340 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -473,36 +473,21 @@ void dump_pageframe_info(struct domain *d)
>
> }
>
> -/*
> - * The new VGIC has a bigger per-IRQ structure, so we need more than one
> - * page on ARM64. Cowardly increase the limit in this case.
> - */
> -#if defined(CONFIG_NEW_VGIC) && defined(CONFIG_ARM_64)
> -#define MAX_PAGES_PER_VCPU 2
> -#else
> -#define MAX_PAGES_PER_VCPU 1
> -#endif
> -
> struct vcpu *alloc_vcpu_struct(const struct domain *d)
> {
> struct vcpu *v;
>
> - BUILD_BUG_ON(sizeof(*v) > MAX_PAGES_PER_VCPU * PAGE_SIZE);
> - v = alloc_xenheap_pages(get_order_from_bytes(sizeof(*v)), 0);
> - if ( v != NULL )
> - {
> - unsigned int i;
> -
> - for ( i = 0; i < DIV_ROUND_UP(sizeof(*v), PAGE_SIZE); i++ )
> - clear_page((void *)v + i * PAGE_SIZE);
> - }
> + BUILD_BUG_ON(sizeof(*v) > PAGE_SIZE);
> + v = alloc_xenheap_pages(0, 0);
I know this is only interim until the next patch, but
alloc_xenheap_page() to match the free function used.
Personally, I'd merge patches 2 and 3 together, because everything you
touch in this patch is deleted by the next one.
But, whatever the ARM maintainers prefer.
~Andrew
|
