[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH] xen/domctl: add XEN_DOMCTL_CDF_ALL mask
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
- Date: Thu, 18 Dec 2025 17:20:09 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZOw/OiQ9Hk6l/jPFyr2PywTlt1wkFNHno9E2uN0CUPc=; b=WlYjGz4hWXKjlaP7Ayb9o00KMt/ZUxxJfnswfFYtPH7WwBWceb+BQRUGQwAIWAHdOkSBNKZW0ZM2GH7vrZkv/C/eda20dwhzTghoqt/M+aPt+K/W9gObkZZiwVNUlZL/+8hJP1kiBYB4jdtoc+5I8GQhA/x2cN+5/413clouuV+MA2XeX4n+u8uKBlWdT/hAG7CAJBKSpTiyS/3ICgSl5OTBCwj3fXMHK9Sbbg+rfZHKEickucduGtU33rClz8RZEwxVuVs2GdDdE6+5n92PD+WzgHYZhMezH1tVa8pHW+JPl9MNEzSUdV9zp8XNr05jfDj5I/xzTaAUhDrFbFeNzg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LrrbkNah4+aJXvOpGP77fQGHLkHYuGf7HrSBd5uAVhhEnnTlfhZ8D50cj7p/p+GxtUs61VlbnSSWXlcCMd2KjWrqaZTmpE6qKJME9oK3zcxycOg7aTasOnEwd1gTrn2OLaQ/D6+8HlmS+MwxiUSyCbSfgSXbAcekWVmgPKr5/J1AgDgyivvwotOl21Me63dJXlANcpsChzWmtzcInh9dt0kTma9FXVFZBTiY9h1SplyJpc7TEQGVIVK9bAokSZSOSouL+sec2k8/ok4Z5tDlAPLvHkPGNKswfWX3S+PoLzsLYb7XgVAn1/azmuuQowJmMmBT3qOJftJH1BlVfIPSQw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 18 Dec 2025 15:20:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.11.25 22:16, Grygorii Strashko wrote:
From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
Every XEN_DOMCTL_CDF_x flag:
- is defined in public/domctl.h
- explicitly listed in sanitise_domain_config() (common/domain.c) to form
mask containing all supported DOMCTL_CDF flags for "Unknown CDF flags"
check.
So, it is required to modify two files every time XEN_DOMCTL_CDF_x flags
set is modified.
Simplify the things by introducing XEN_DOMCTL_CDF_ALL mask, so
sanitise_domain_config() no need to be modified any more.
Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
---
Seems nobody interested, sad, dropping from backlog.
xen/common/domain.c | 7 +------
xen/include/public/domctl.h | 7 +++++++
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 775c33928585..4f91316ad93e 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -730,12 +730,7 @@ static int sanitise_domain_config(struct
xen_domctl_createdomain *config)
bool iommu = config->flags & XEN_DOMCTL_CDF_iommu;
bool vpmu = config->flags & XEN_DOMCTL_CDF_vpmu;
- if ( config->flags &
- ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
- XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
- XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
- XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu |
- XEN_DOMCTL_CDF_trap_unmapped_accesses) )
+ if ( config->flags & ~XEN_DOMCTL_CDF_ALL )
{
dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
return -EINVAL;
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 8f6708c0a7cd..94a8e3042cbf 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -72,6 +72,13 @@ struct xen_domctl_createdomain {
/* Max XEN_DOMCTL_CDF_* constant. Used for ABI checking. */
#define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_trap_unmapped_accesses
+#define XEN_DOMCTL_CDF_ALL \
+ (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
\
+ XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
\
+ XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
\
+ XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu |
\
+ XEN_DOMCTL_CDF_trap_unmapped_accesses)
+
uint32_t flags;
#define _XEN_DOMCTL_IOMMU_no_sharept 0
--
Best regards,
-grygorii
|
