[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] tools/libxc: Delete ENOSYS squashing in xc_domain_claim_pages()


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 17 Dec 2025 17:29:31 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tUUA2dbaYyRkhI72bQIFl/s45CQ0WeI786O5IMh3KAE=; b=Gy35SPxC/OztlQediihDARRdFh72W+aDxUMcSLJ3uh8MGSyjem2y+r4B5byj3XaPXzx7Q+eGknHCT2WwBRgC3jJb69RTQUVG8kLYAm1ZvWhA9YBjn6YQGj55KQ9iFxq209pio/tfdT1c5LqahbLucqTWmz4Ozgk0K+zySj5xXAO0BmCB+IQstSkay/x6le48NFBkT2Dzxh43TqzJNpCO3bK8zD1NVSYwYXr47wFgSKjVEJ9o1NkxCLdj41e0Z3qogRfqX/I5znrgee3ZPpTRNAJ/TMUELMGNkJaFOio6Z4m0accwMWaoN5XSSICp5VhMehifydmvMR7h5FRA7ekqJQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DdyA7uuZKxdrMCJ/DO4V5SrB0HPAWQ5m0AnmJb6cXIpl3GEQWcW5Mio6xEZazq3r+c9E509eG1JJd5u6Xx84k3jCSSJ1ekbWhY7+8e/Y5leS24sutobGCmb7StV9j6kYC/N1m6a/PIs7q2LWXPMSHPiGRGOpZiKQOFecLDKcaWqKa3hDD2kmjl40WDoy33i809XMt1CiG2CV8pbK5WRSmZ1TrvU3peiSBGaBpWlUMTA5P0RUiqlnANDTAI5Jdls8knMMnRENnOVj0r3g1OU/g6OIOyMGa6EaAoSCHFeq8p2CSlb7TGKkqXVkGkXPiDQoxsHaC9zNq0NPuxwibhijXA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Wed, 17 Dec 2025 16:30:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Dec 16, 2025 at 04:32:28PM +0000, Andrew Cooper wrote:
> It's not acceptable to hide this from the caller; the effect of doing so is to
> break an atomicity expectation.
> 
> Only the caller can know what the appropriate safety action is in the case
> that the claim hypercall isn't available.
> 
> Fixes: fc67e9dc0c1f ("xc: use XENMEM_claim_pages hypercall during guest 
> creation.")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.