[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] gic: Replace BUG() with ASSERT_UNREACHABLE() in LPI paths
- To: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 16 Dec 2025 09:38:30 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dDCsW65i7qm+NHFKpRQwMSiyGeC4ZTpkMdoTaSGsOOw=; b=UQQ3XPPkQpnl1z95RwZngyPowOniTUbw0Xtomas0bixtYRJG8WLisP4rjm3WP7r6aHmeYkbg8SAsfh+a4vhOcoUPoh3vyFXO1No1EKrDB2jvfGwT+fCX59bRNy4tAuXDJSRGbGWbX71/F/umE9Y7OW4rcXXA54vQQWQ/aetLDCJ9w4yXnRr2k7mF3Ex9mKMkJ22WZlzfx0u28nfMtrGM2zwDNDs3t97U3jIlUKOJ3uKIZgvOrPtrZbSPkBLtazuB+j31aa4QIqf3wONXbOriuHGZhrTLRIWfomPcaAJUHjosMAK0MBuG/jfAPN4Vv25REGaYebWxlTVuCj+7/kTd6A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BoeEgqMTyW4EIgTYRkS9/PX0x7JxXXXinxLj7LQ5gBJjN58K2mzpkMgum3HWOOJBzxCxx57H8ed/XhJHFjmpWZdE9wpDsEBkB5QMNPBII7Sstb+ZBIgfNMdUfe++Jjn3cVr+phuvrGEclBkL76iUVqU0YEDr9d9M0OF3srzlBNU6DnqXRZ5XPS8xyaJgdm44TOzUOOJSkdEpgW+UybWF7KajCl4xb5+zHs57QKernIM6Zn3Qj3FtC+D/9D3el8VO8s/qdsnKuWabQhm1eTWT6VlKqM8EHPuqayZ+3p7WLgmr4N/AbHmoi41bUJhw3+gEKb41/kf3fAnpEEk2nJ6iVg==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 16 Dec 2025 08:38:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/12/2025 09:22, Dmytro Prokopchuk1 wrote:
> MISRA C Rule 2.1 states: "A project shall not contain unreachable code."
> The GIC LPI driver callbacks violate this due to the use of the BUG()
> macro, which causes the function to never return.
>
> Swap BUG() for ASSERT_UNREACHABLE() to satisfy the rule without needing
> an additional deviation.
>
> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
