[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/domain: enable VCPUOP_register_runstate_phys_area hypercall
- To: torsten.oehlenschlager@xxxxxxxxxxx
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 15 Dec 2025 17:55:00 +0100
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: Andrew Cooper3 <andrew.cooper3@xxxxxxxxxx>, Sstabellini <sstabellini@xxxxxxxxxx>, Julien <julien@xxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 15 Dec 2025 16:55:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.12.2025 22:01, torsten.oehlenschlager@xxxxxxxxxxx wrote:
> ice@blossom
> ..............................................................................................................................................................................…/xen
> 🌸 enable-runstate-phys-area ?
> ❯ cat 0001-xen-domain-enable-VCPUOP_register_runstate_phys_area.patch
I don't quite understand what this is.
> From 416992b30258d34b7cc7bc4f7875719f47618147 Mon Sep 17 00:00:00 2001
> From: melanie <torsten.oehlenschlager@xxxxxxxxxxx>
> Date: Fri, 12 Dec 2025 20:55:50 +0000
> Subject: [PATCH] xen/domain: enable VCPUOP_register_runstate_phys_area
> hypercall
>
> The XENFEAT_runstate_phys_area feature is unconditionally advertised to
> guests via XENVER_get_features ( see xen/common/kernel.c ), but the
> corresponding VCPUOP_register_runstate_phys_area hypercall was disabled
> with a placeholder check that always returned -ENOSYS!
Well, no. The check you remove ...
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -2284,10 +2284,6 @@ long common_vcpu_op(int cmd, struct vcpu *v,
> XEN_GUEST_HANDLE_PARAM(void) arg)
> {
> struct vcpu_register_runstate_memory_area area;
>
> - rc = -ENOSYS;
> - if ( 0 /* TODO: Dom's XENFEAT_runstate_phys_area setting */ )
> - break;
... is dead code, yes, but it certainly didn't cause the function to
return -ENOSYS. See commit 48a3fd14327f ("domain: expose newly introduced
hypercalls as XENFEAT"), which in a change like this the description surely
should have referenced.
Jan
|
