[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 5/5] x86/shadow: Deviate multi.h as being included multiple times
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Sat, 13 Dec 2025 08:04:54 +0100
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1765609494; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=QE0VF2Mh/n3CA5johqzBBgR7JTADL/vP3EQMxSVaNbg=; b=NtlqIo2uvWPNjAK2UqleS7zLM+Zunp0qTXCxZpIoPOmefU5dlBYt/pKGH9JuUngdvE9m TVcpEUVVqtRXoP7M6suzT9si8M3WXhdwbPQ8j+YysgDx4qQ/x2o9ni6biFV+sPkj6y0g+ az7DTipq1ThfdG/YhDt2hE49S9YbId9SCK01KsAbyWodpeiOznAyMuS+ZGg76kxq9yAd5 elzICafbyBYIBKZv+Zy5JOfRXyV72vlSHdlLZbEdzrc6i19Nl+KMC+r23jYoYob1PqmH+ MIWdg4d8TQv8ar4wsX/DgjOEZ6Lqx109aDYt1JzXphYS+lPNyZqP9gVq9jepen0gdUqlW R/FqG/C7ahNeH631lkrRbtxix7OpV2g7SUJiaw+rVdSs+FYsdeLDKbY1jxFSB1Kwur9tY 9uVdEQyZAB30V3eqE00CV4qv6kbJcpHFVwRrH3NRJFO0ccVpHrN91pQ6WajUOMranWH/w jN5r3tOWM6kZSKa/LigJ6CuiDpiEp4KN73+URVQBwuqELpsVJZlNa5nlikPuSwECEnVUE NOCGKK8YBMJCMySIfm8Sk4dn/NbNpGkCPMfxNq+SxuE27l3sRt9hGe8Vi2hRArwMUXLJH oj8plv0yDLsYeY6QtaSfxzYAKMgsqh5cmXcJ7eSEy+rnLomphga7SmFYTfEjAy0=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1765609494; b=HcU7iz3PF8B4ljCkfL93UMPliDf/lpvsiIo0HEVmGC2l1ljes2Z517CsmTMeCK9EDiNG wvl9UqTtN6PMIfSuDc4goT6O4XcLwX0A3Z8xG6ljig47++7wJ9hxT4E4bHSx2CtyY82rZ jy1gHWABmueo6lHel2SvD9erg6s3ttcpu6pg1zu46B8nlfBor2tyOQYo/FXxo3tYEVz0e T7SysxHHwwv1ck+EwtvhdxBqLMI73hpLIgMENtqXGKpqaaGMeSc/wGpxSPEToG7Y1p4rz gnmUm8J8KLdtIl043RSNtpKfuGhlTy5jS4dCzfJArGM3kgkwGnEom0SOr+RL4I3ga4tYe Y1yBUVWRvOD8tk6cEoGAryH2WVa0aQn8diYtmSwFeqnK2sqZjrU1C5zp25pAVzIikPUop eHfSTb876wgv9QVQ+xxDBRErfCGeczH0jndoNu+tzYhXjPpRt9dhKgrCvdvTx5LK/E0LH K0Mn/yproQ6jm2XjvOGqjGeICPIQ+1kx9oWwvlnODEnLJemt/Svf+OddlnOkSQYM2OMN6 oJHgr6HnPhdgs4/xYWBGybKWMmDP5D/Qh0G5LAZzD9thhgzVr42l0DktHy9EsraroC6Uv I0DYlP4JoHcle0SlEWxIrh7iFzw6sGXqyB3BgPyx1Ar8wbdlRSS509u8ACfsrCA=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "consulting @ bugseng . com" <consulting@xxxxxxxxxxx>
- Delivery-date: Sat, 13 Dec 2025 07:05:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-12-12 23:20, Andrew Cooper wrote:
This resolves the Eclair complaint about a MISRA D4.10 violation.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
CC: consulting@xxxxxxxxxxx <consulting@xxxxxxxxxxx>
CC: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
RFC - this doesn't actually squash the violation, despite being the
requisite
magic string. I suspect the Eclair config needs tweaking to allow the
magic
anchor string to be after the SDPX tag.
---
I think it's just a matter of positioning. The location of the violation
is at line 11 (the first non-comment statement of the file, and the
string is matched in a range of -4 lines from that point:
-config=MC3A2.D4.10,reports+={safe, "first_area(text(^/\\* This file is
intended to be included multiple times\\. \\*/$, begin-4))"}
so I think moving it just below the copyright lines or increasing the
range should do the trick.
xen/arch/x86/mm/shadow/multi.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/xen/arch/x86/mm/shadow/multi.h
b/xen/arch/x86/mm/shadow/multi.h
index fc86d7a8d9cd..b4a6cf1362a6 100644
--- a/xen/arch/x86/mm/shadow/multi.h
+++ b/xen/arch/x86/mm/shadow/multi.h
@@ -2,6 +2,8 @@
/******************************************************************************
* arch/x86/mm/shadow/multi.h
*
+ * This file is intended to be included multiple times.
+ *
* Shadow declarations which will be multiply compiled.
* Parts of this code are Copyright (c) 2006 by XenSource Inc.
* Parts of this code are Copyright (c) 2006 by Michael A Fetterman
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
