[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] CI/eclair: Rename the eclair-* jobs to *-all and *-amd



On Thu, 11 Dec 2025, Andrew Cooper wrote:
> The *-safety jobs are AMD's configuration specifically, and other
> configurations will likely be different.
> 
> Give the un-suffixed job an *-all suffix to make it clearer what they're
> doing.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

This is straightforward:

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

I like this and I think we should also rename eclair-x86_64:on-schedule
and eclair-ARM64:on-schedule for extra clarity. For instance:

eclair-x86_64-allrules:on-schedule
eclair-ARM64-allrules:on-schedule

It could be in this patch but also in a different patch.


> ---
> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> CC: Michal Orzel <michal.orzel@xxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Julien Grall <julien@xxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: consulting@xxxxxxxxxxx <consulting@xxxxxxxxxxx>
> CC: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> ---
>  automation/gitlab-ci/analyze.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/automation/gitlab-ci/analyze.yaml 
> b/automation/gitlab-ci/analyze.yaml
> index 20cabbe5f70c..37a941bebbae 100644
> --- a/automation/gitlab-ci/analyze.yaml
> +++ b/automation/gitlab-ci/analyze.yaml
> @@ -39,7 +39,7 @@
>        allow_failure: true
>      - !reference [.eclair-analysis, rules]
>  
> -eclair-x86_64:
> +eclair-x86_64-all:
>    extends: .eclair-analysis:triggered
>    variables:
>      LOGFILE: "eclair-x86_64.log"
> @@ -58,7 +58,7 @@ eclair-x86_64-testing:
>        when: always
>      - !reference [.eclair-analysis:triggered, rules]
>  
> -eclair-x86_64-safety:
> +eclair-x86_64-amd:
>    extends: eclair-x86_64
>    tags:
>      - eclair-analysis-safety
> @@ -99,7 +99,7 @@ eclair-x86_64-safety:
>        when: always
>      - !reference [.eclair-analysis:triggered, rules]
>  
> -eclair-ARM64:
> +eclair-ARM64-all:
>    extends: .eclair-analysis:triggered
>    variables:
>      LOGFILE: "eclair-ARM64.log"
> @@ -118,7 +118,7 @@ eclair-ARM64-testing:
>        when: always
>      - !reference [.eclair-analysis:triggered, rules]
>  
> -eclair-ARM64-safety:
> +eclair-ARM64-amd:
>    extends: eclair-ARM64
>    tags:
>      - eclair-analysis-safety
> 
> base-commit: abac3b76d20ebecb339cb41bb8982796bf1ce276
> -- 
> 2.39.5
> 

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.