[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/5] x86/ucode: Don't cast away const-ness in cmp_patch_id()


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
  • Date: Wed, 10 Dec 2025 21:37:08 +0100
  • Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
  • Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1765399029; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=1RXVffh6wiq/ymvU4iZWe5oifI/6dxTQnQPN9i1zS+Q=; b=cY8fn2hbnKY08mWlZ8pG1kq/FbKVlc0txTXR10ZA+A2UOsrSfZFSDOcYNqHycayNNMDJ 8sUw5KZ7LRWX6yempE96j0e+LkVyVMEMxv4w1RyWqK89TAyyP2S3oIXgJ5BA00/58kVDc d+j/QPxVA5O20N1F4rqCoSgk5SBK0TgPgl3YAN8N+j0wOVuY2C+6qjmWA9VE2RTtuUn04 yVH3esTutob8CN5Q5dFx2WMaGFVPziYJlIc62gP6wjzsHXXwLGCn6EnrK1Y/6DXh+rbWX 9FCX0x7oeNT2IPAJ27Cac/j5WmgfyOuW8luhuEXgVOvSkPO3fUflB6SOy45i0Yp2kvb1p Wny1Vn11B4qoq/HeN/2B7gS7cNHc914DQpUWz9XCYJMjFOiG4JZ2rtOM8gt0jSPE00TFg o/w0pNZlKA7xzPjH4EXSLO4d/5LPQOkQBE990sHQVZCH0iMCzjoid0oXB0eQnRcyMLhNI OFecmB5kljC/THgBH3OOFx7ys9q4nHV0adUJiY4Qdn3ikRIGEzuNfEx+2ErbpfRx4R6I1 YtzsM8hjOMGxpNo8rUieQogcvv/NsyNs7Mwc45h4BYSZFgsM/594yDr5oJ+CNkvlhWHhE 7vNu3MLAVDCqKg7geNg4yTmlWeKo+mv3lPGik2JC3OqW1EZ27VYGFLMb+9htqCs=
  • Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1765399029; b=kmZrx2gRavTVlI80sQ0oLFOPMvz8CoAjYGuGBsBgy0O6vtqXmpmfDiFCASydRj63c84i jqqFlsBVGTV1MyvuGPbAvQGdtbwGn5HXHImmytv3rWwZbZya2Y/9F/zt55xp+3RmZQlnc xN9QECjiDT804rFlqq0EpZBVPZ2k4MQGjSGm778DOVOoOrWeyDxmZTlscGkYvHLDDPvDk Yg+TmlLdhEqnfFQlrYNkcB/YieKmk3+elYk53xm1dKAFa0nB7KEHryOk8XF6mageU2dmC le6aZTRhtMMjTEVkxMKvqsyfpor84Dhu+cVNO2deYL7cgXu+B+8ipduA2PBjPuqzfPJA1 2jNVSi9dxk0aDnZek7ehxeMwbrQq2Gg0y/ZNuU2BtMtfWGR4dKo6FtFS4hYlbHl4rR5ik NAKRMi5xMY0APnmgCvbaCcveW2kv4t35l3SFetO5Bflt7+PJl050jQA44nmH7DUf+22K8 l5/VYITvL/tRvdBwEX2LRNbwJX8EsaGf3MlstAGCDa3yB7pjNL+LLJ2/hePX0XSNt2qqv guFKzAzk2aldqCh4Nywykk5XF5KNxw6cY47fVeIB/SYQgkSxzrDrPhDblRPpA6JSPgjEN bsF2GAtZtCc/wU8ilOYKXkgG09E/idoj1/m0kGxhGnDr1Hkc/Pya7UrEbfiysT0=
  • Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "consulting @ bugseng . com" <consulting@xxxxxxxxxxx>
  • Delivery-date: Wed, 10 Dec 2025 20:37:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-12-10 19:30, Andrew Cooper wrote:
Fixes a volation of MISRA rule 11.8.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
CC: consulting@xxxxxxxxxxx <consulting@xxxxxxxxxxx>
CC: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
 xen/arch/x86/cpu/microcode/amd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/cpu/microcode/amd.c b/xen/arch/x86/cpu/microcode/amd.c
index adabe6e6e838..2760ace92177 100644
--- a/xen/arch/x86/cpu/microcode/amd.c
+++ b/xen/arch/x86/cpu/microcode/amd.c
@@ -106,7 +106,7 @@ static bool __ro_after_init entrysign_mitigiated_in_firmware;
 static int cf_check cmp_patch_id(const void *key, const void *elem)
 {
     const struct patch_digest *pd = elem;
-    uint32_t patch_id = *(uint32_t *)key;
+    uint32_t patch_id = *(const uint32_t *)key;

     if ( patch_id == pd->patch_id )
         return 0;

--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.