Re: [PATCH v3 3/3] xenpm: Add get-intel-temp subcommand

["Teddy Astie" <teddy.astie@xxxxxxxxxx>]

Le 10/12/2025 à 09:50, Jan Beulich a écrit :
> xc_resource_op() doesn't return errno values, so by using -EOPNOTSUPP here you
> put the caller into a difficult position when actually looking at the return
> value: Does -1 mean -1 or -EPERM?

That's a bit unfortunate as xc_resource_op() can return either -1 or
some -errno; so -1 could be either -EPERM or a internal failure of
xc_resource_op and we can't really know.

One thing is certain is that if xc_resource_op() returns ret >= 0, there
is no failure aside that we may have no data (e.g no MSR yields a value).


--
Teddy Astie | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech