[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/8] symbols: drop symbols-dummy.c
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 8 Dec 2025 14:51:58 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=suse.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o3BSPOOP7AZnjusguqzx0kCWp/NJwjqsq682neBhWls=; b=PvtUUK+mCKgeRTLUvt63DWl6dxMvE/fJ3PMbX8lwm4m4eMFUO9FVhHz1tPnPn0OCfXpeHf2p/wEWKAkL0KDo31CGkKFSE8k8XS5skfG/t3IOGwuEGoq4rmwlUum9k2A3G7wOdMgQYFc/lVBU3paP7AhknbE1VVp5f9FN9OJLa8lRvpye8lwpZZ58D8DLz8Z6nRolQq90QtxdG7upX6FPbJi5q7YVbiWEyyukioOnAqKuYuKFIETgOKBzqJ8LfmWerSrNCjuzsyIV9Xxm7pdRsfTE2et4c7XX6OGExnRaBR4u1YMXIzfapDnpP3LNC8JGMK5sQF1CUE9VvBFgqjvv5Q==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o3BSPOOP7AZnjusguqzx0kCWp/NJwjqsq682neBhWls=; b=vzwbglC3fTxQ1Pi1ONMqD2KmmOuvP7pwkPt7tCCMzE6cZQieDyoVx3fAKyGMfALMMvM4yPcIV86p1yBgG28tsikHzUHz1u/l7225AqpRllSmt+ugo9OFnrkLzfm8MWAKydzzN/fn+cshQA6UtRDSMV8k84oWzlvl3UCxe8s1J4CoBGHnGp3HPDb3h85f406wfMQgJUEtYXCqVIoYtX6AWVweRnZqx6hdW8G/oZ3OOv7FK2UWWz6tMNRGHK3A93U54MYt3NyGxeS3uON/Qs8aTkZPDMxGeN7NLOT8cco/3xtatm3VvfBMURmrNQezeD2GLfCbRCV9NuMGgsXDqTQPow==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=AdBi7To3PBWzx5LraHpM887QoFM47+RnjUQmxMqjQybObkB33YfScIaKGJW/xLKNaj/I59BlQ6BcWzDINawQolzF3j0b3t9aizI01FJznkKs1ppPwVRi3QA2jVRJGeLsHEAIpDCTxHU6Gvzq5WBxRXQzM0fdtyuoPsHkgYPnGyYiq9JajS2mlo6qbMPmkJzCR7ThPnNjdO4GK7Z7KJR9liQwKB2zY/yeAJ9iH0jNq7KHzwvHFRrW61fx8nxjyUDPL1h1awviUWV0hR5kKdFo/46vl8Ukso0OGSJYemYwfvJfL3wT9Yx3y6NzMb50w69NLaOSWixBTWeeemAICI50jA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oGbvWCgcSqYw5EYOxqSdGAzyQAYcVYOGMituV9AvJ979yRKd8UQKx3qcwC9qLj3dxIXnE9HanJNj8/umXohvIAWXC1lHoz6EhAnktqOf3k5BNMkcI18NVWCuP3J4LjfDXDAtjdrAVpBBGCdsLRSZcHc4nPHeWduYxKI4FBgvArWVjOjyH/j/uBvuMFpm4jaulQC9Xr9Ezj+V39gwQOeacMIeW5Lw1QUCh28SlDBjdqlC0lo54G5izoRzvyyEL63ZTjJWfYzRZTEZs2FV1Zchx775DNxEaMS5nTODN7eaSIe9xg+nUJ+yK43FvtdqkG4c1D3unJKxAPgf90WGs1azrw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 08 Dec 2025 14:53:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcaFHEZgCWYRtzmkm7gvYg23aA3rUX05+A
- Thread-topic: [PATCH 7/8] symbols: drop symbols-dummy.c
Hi Jan,
> On 8 Dec 2025, at 14:48, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 26.11.2025 14:47, Jan Beulich wrote:
>> No architecture using it anymore, we can as well get rid of it.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> Should we also drop common/symbols.h again then, by moving its contents
>> back into common/symbols.c?
>>
>> --- a/xen/common/Makefile
>> +++ b/xen/common/Makefile
>> @@ -74,8 +74,6 @@ ifneq ($(CONFIG_PV_SHIM_EXCLUSIVE),y)
>> obj-y += domctl.o
>> endif
>>
>> -extra-y := symbols-dummy.o
>> -
>> obj-$(CONFIG_COVERAGE) += coverage/
>> obj-y += sched/
>> obj-$(CONFIG_UBSAN) += ubsan/
>> --- a/xen/common/symbols-dummy.c
>> +++ /dev/null
>> @@ -1,24 +0,0 @@
>> -/*
>> - * symbols-dummy.c: dummy symbol-table definitions for the inital partial
>> - * link of the hypervisor image.
>> - */
>> -
>> -#include "symbols.h"
>> -
>> -#ifdef SYMBOLS_ORIGIN
>> -const unsigned int symbols_offsets[1];
>> -#else
>> -const unsigned long symbols_addresses[1];
>> -#endif
>> -const unsigned int symbols_num_addrs;
>> -const unsigned char symbols_names[1];
>> -
>> -#ifdef CONFIG_FAST_SYMBOL_LOOKUP
>> -const unsigned int symbols_num_names;
>> -const struct symbol_offset symbols_sorted_offsets[1];
>> -#endif
>> -
>> -const uint8_t symbols_token_table[1];
>> -const uint16_t symbols_token_index[1];
>> -
>> -const unsigned int symbols_markers[1];
>>
>
> Now this is (to me at least) absurd: I'm removing a file, just to find the
> pipeline
> fails because cppcheck doesn't like docs/misra/exclude-list.json containing a
> reference to a non-existing file.
>
> I'll amend the commit with
>
> --- a/docs/misra/exclude-list.json
> +++ b/docs/misra/exclude-list.json
> @@ -170,10 +170,6 @@
> "comment": "Imported from Linux, ignore for now"
> },
> {
> - "rel_path": "common/symbols-dummy.c",
> - "comment": "The resulting code is not included in the final Xen
> binary, ignore for now"
> - },
> - {
> "rel_path": "crypto/*",
> "comment": "Origin is external and documented in
> crypto/README.source"
> },
>
> but I think such tidying should be optional.
>
> Jan
Can you share the error?
Cheers,
Luca
|
