[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 1/2] Do not attempt to workaround older binutils
- To: Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 5 Dec 2025 17:44:42 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bHnyBkRa5Ya2hGFkympgSn7RaXo9YdtHW0E2IgG5Ek0=; b=VxERUHCIuw8c04JPoE312FxU5P8zSTo++GeYE3r6FSihhbVP9YjffsP7RwsMxcJptKXICW05Qe57hgN/7jc7+rWxgLeX6jCvpgjHjjJB7w+TqaOsKGonh80JFn1waxnEHnChUfnPLGv7spRxPbAa4Ga7vw4o6+j91xf8CdwB7v6GNrkbOAYUONQSns6ueH7Y4ktW52g5P860HhM7q7aMPc9JqVxKwWNrbfoII2WXM14LeToGOZ8+t6HAQhMvyS/cON7zcgpdGyvXGiRMhrM3AuQLbr1k6+kTZkUhEKs5LQbcGbGA8m7nYGi8aAr5ipwdIumT4kXP4epNgudtaYpd/Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ahfgWCuuvcGjic9Oqznl6ym9gQCLkItxFsMFR9pSPwxjNaDICaaOvxe3cxwhyagkp1yptg1ibu6dxxPx/mknGgHmveVGuqLSecEG9Zht2B9iTkddJ8Ys/7Z6L9xCQED1yaVKnpTwzKb+lMGcSqUM6293TBmSHnVEuPM1GPR8rjYPk+5lXOJczDsEpL11PhG1rinKVbMrm7fJsKEMpRDqDe7YOqJr7DCf+tgtMih8qHjM9Mjl2G4nQdnff6FmRmASlWV4yu2m4ZRICQof86l7DFV9LnE9gzTPUXdpa8Bd3DTTHiW6cngbMcV/hZqW+Be3LE3VPwQIAeywhmxx6GIXpQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: andrew.cooper3@xxxxxxxxxx, Frediano Ziglio <frediano.ziglio@xxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Frediano Ziglio <freddy77@xxxxxxxxx>, Demi Marie Obenour <demiobenour@xxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Fri, 05 Dec 2025 17:45:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/12/2025 4:09 pm, Frediano Ziglio wrote:
> From: Frediano Ziglio <frediano.ziglio@xxxxxxxxx>
>
> Older binutils versions do not handle correctly PE files.
> It looks like they could work if they don't produce debug information
> but they mess the PE file in other way like putting invalid
> flags in sections.
> Also different tools will complain about the format (like
> objdump and strip).
>
> Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxx>
> ---
> xen/arch/x86/arch.mk | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
> index 16368a498b..10eb8e4292 100644
> --- a/xen/arch/x86/arch.mk
> +++ b/xen/arch/x86/arch.mk
> @@ -88,13 +88,6 @@ EFI_LDFLAGS := $(patsubst -m%,-mi386pep,$(LDFLAGS))
> --subsystem=10 --enable-long
> LD_PE_check_cmd = $(call ld-option,$(EFI_LDFLAGS) --image-base=0x100000000
> -o $(efi-check).efi $(efi-check).o)
> XEN_BUILD_PE := $(LD_PE_check_cmd)
>
> -# If the above failed, it may be merely because of the linker not dealing
> well
> -# with debug info. Try again with stripping it.
> -ifeq ($(CONFIG_DEBUG_INFO)-$(XEN_BUILD_PE),y-n)
> -EFI_LDFLAGS += --strip-debug
> -XEN_BUILD_PE := $(LD_PE_check_cmd)
> -endif
> -
> ifeq ($(XEN_BUILD_PE),y)
>
> # Check if the linker produces fixups in PE by default
Given the practical breakage, it's clear that noone's using xen.efi
generated from toolchains these old.
So, while it's not completely ideal to be "dropping" xen.efi on such
systems, it firmly seems like the right thing to do overall.
EFI support is still available on such systems via xen.gz + MB2.
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
