Re: [PATCH] systemd: default system-sleep dir without pkg-config

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 05/12/2025 2:54 pm, Mykola Kvach wrote:
> Hi,
>
> On Fri, Dec 5, 2025 at 3:57 PM Marek Marczykowski-Górecki
> <marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote:
>> On Fri, Dec 05, 2025 at 03:13:32PM +0200, Mykola Kvach wrote:
>>> From: Mykola Kvach <mykola_kvach@xxxxxxxx>
>>>
>>> Using PKG_CHECK_VAR() to obtain SYSTEMD_SLEEP_DIR reintroduced a build-time
>>> dependency on systemd-devel. This breaks --enable-systemd builds that only
>>> need the initscripts.
>>>
>>> Use the same defaulting scheme as other systemd paths: if SYSTEMD_SLEEP_DIR
>>> isn't provided, set it to "$(prefix)/lib/systemd/system-sleep/".
>>>
>>> Fixes: e54a6cd6a1f3 ("systemd: Add hooks to stop/start xen-watchdog on 
>>> suspend/resume")
>>> Reported-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>>> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
>>> ---
>>> Build in which the regression was detected:
>>> https://gitlab.com/xen-project/people/marmarek/xen/-/jobs/10959608099
>> Requires re-running autoconf, otherwise still fails:
> Thanks for the note. I had assumed the Autoconf-generated files were refreshed
> during release or at merge time, since this updates generated artifacts. If 
> the
> expectation is that contributors regenerate and include them with the patch,
> I will add the updated Autoconf outputs in the next revision of this series.

We regenerate on commit, but that still needs a reminder to remember to
do so.

>
>> https://gitlab.com/xen-project/people/marmarek/xen/-/jobs/12336879267
>>
>> With autoconf:
>> https://gitlab.com/xen-project/people/marmarek/xen/-/pipelines/2198372475
>>
>> It's better now, so:
>> Reviewed-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks for the quick turnaround.  I'll queue this shortly.