[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 09/10] x86: use / "support" UDB
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 5 Dec 2025 13:15:49 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jOykeCTpePIvtWiD1Dvq2KGyJsfAGfQ7e/xguK3wZJ8=; b=vL/1lWInFKh8h5ju1CPuSfOTzLK9S0N+qSw6+EemOvo6qr+JYGKHVc2TJcvUv+rVBx4lyC/vGSkL1WzJ/LYRGjYIGOa5tWi72MoaWew312nv1P33JleH4ppQl25EI6sNkuj01JLqzbfo0qngmz7M4InEVJTYZ+/vgaNnupq4Qew5UXro2B8164QPgV33/bwKIlV4AxnV7h58QTQ78Qk2TvCJeuxQX79kFP93DxphXEJlUMewQjStvZes0wB/euNgYyvVGtbC86HUFUv5zo/xUUUdO6Ol522uv5+e0bfR+2h6Qo9+/esjkur/ex2w/thh8/NW0N+A+PG0MN6S9NRHhw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BimaHZLkNhrdN5DHt6aSyKWdgCl/1Fszp1d6G+k4Lvz4kivqqqKynoLOu8LUO29jdRWhxpD14DpkNQJ6LGlwtQkuWrs50lC/0pPhwHncwKmGu4Mg8Fu5ZTZvizkWpy4A+jxELJOpN3hUerraTCqRASkCF+GTwp244+PNb6vhzZGC7iIxlmaT2uBeWscCi2uDUvll7yRwRAebIG6QuazaWdOzAD5+NhrLevYGncAGouo2s08gVgqH3jSIQA4TLpvKQOcWOZ2zWfwBp92G1Mh7sQlliFJQ1jS7NNbbJ/j6y09Zcbu3sDEcmzx7wcoQPn4ZMkRrwmNlAnKCM/82+gt1nw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: andrew.cooper3@xxxxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 05 Dec 2025 13:16:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/12/2025 1:13 pm, Jan Beulich wrote:
> On 05.12.2025 13:40, Andrew Cooper wrote:
>> On 05/12/2025 12:01 pm, Andrew Cooper wrote:
>>> On 24/11/2025 3:01 pm, Jan Beulich wrote:
>>>> --- a/xen/arch/x86/include/asm/bug.h
>>>> +++ b/xen/arch/x86/include/asm/bug.h
>>>> @@ -21,7 +21,7 @@
>>>>
>>>> #ifndef __ASSEMBLY__
>>>>
>>>> -#define BUG_INSTR "ud2"
>>>> +#define BUG_INSTR ".byte 0xd6" /* UDB */
>>>> #define BUG_ASM_CONST "c"
>>>>
>>>> #else /* !__ASSEMBLY__ */
>>>> @@ -37,7 +37,7 @@
>>>> .error "Invalid BUGFRAME index"
>>>> .endif
>>>>
>>>> - .L\@ud: ud2a
>>>> + .L\@ud: .byte 0xd6 /* UDB */
>> P.S. Presumably binutils is going to learn a udb mnemonic at some
>> point? Can we include a version number in the comment?
> I has already learned it, so it'll be available from 2.46 onwards. I've
> added a comment, but aiui we'd then need to also cover Clang's integrated
> assembler (if and when that gains support). In the meantime I've made both
> comments say "UDB, requiring gas 2.46".
Thanks. Clang Trunk doesn't currently know it.
https://godbolt.org/z/ccrhzq95h
~Andrew
|
